Re: Ping^2 [PATCH, rs6000] Correct match pattern in pr56605.c

Hi Segher, Yes, the old committed patch caused it matches two insns. So I submitted the new patch which fixes the problem. Here is the new patch. https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590958.html The new pattern is: /* { dg-final { scan-rtl-dump-times {\(compare:CC \(and:SI \(

Re: Ping^2 [PATCH, rs6000] Correct match pattern in pr56605.c

On Tue, Apr 19, 2022 at 04:05:06PM +0800, HAO CHEN GUI wrote: >I tested the test case on Linux and AIX with both big and little endian. > The test case requires lp64 target, so it won't be tested on 32-bit targets. > > On big endian (both AIX and Linux), it should match > (compare:CC (and:SI (

Re: Ping^2 [PATCH, rs6000] Correct match pattern in pr56605.c

Hi, I tested the test case on Linux and AIX with both big and little endian. The test case requires lp64 target, so it won't be tested on 32-bit targets. On big endian (both AIX and Linux), it should match (compare:CC (and:SI (subreg:SI (reg:DI 207) 4) On little endian (both AIX and Linux), it

Re: Ping^2 [PATCH, rs6000] Correct match pattern in pr56605.c

On Wed, Apr 13, 2022 at 04:30:36PM -0500, Segher Boessenkool wrote: > This should have been tested on Linux as well: it is now broken on both > -m32 and -m64 there. Please revert? Sorry, confusing with another new regression: this one is only -m64 of course. Segher

Re: Ping^2 [PATCH, rs6000] Correct match pattern in pr56605.c

On Mon, Apr 11, 2022 at 08:54:14PM -0300, Alexandre Oliva wrote: > On Apr 7, 2022, HAO CHEN GUI via Gcc-patches wrote: > > > Gentle ping this: > >https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590958.html > > Thanks > > >> On 28/2/2022 上午 11:17, HAO CHEN GUI wrote: > > >>> This

Re: Ping^2 [PATCH, rs6000] Correct match pattern in pr56605.c

On Mon, Apr 11, 2022 at 08:54:14PM -0300, Alexandre Oliva wrote: > How about this less strict change instead? > > ppc: testsuite: PROMOTE_MODE fallout pr56605 [PR102146] > > The test expects a compare of DImode values, but after the removal of > PROMOTE_MODE from rs6000/, we get SImode. Adjust t

Re: Ping^2 [PATCH, rs6000] Correct match pattern in pr56605.c

On Apr 7, 2022, HAO CHEN GUI via Gcc-patches wrote: > Gentle ping this: >https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590958.html > Thanks >> On 28/2/2022 上午 11:17, HAO CHEN GUI wrote: >>> This patch corrects the match pattern in pr56605.c. The former pattern >>> is wrong and

Ping^2 [PATCH, rs6000] Correct match pattern in pr56605.c

Hi, Gentle ping this: https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590958.html Thanks On 15/3/2022 上午 10:06, HAO CHEN GUI wrote: > Hi, > Gentle ping this: > https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590958.html > Thanks > > On 28/2/2022 上午 11:17, HAO CHEN GUI wro