On Mon, Apr 11, 2022 at 08:54:14PM -0300, Alexandre Oliva wrote:
> How about this less strict change instead?
>
> ppc: testsuite: PROMOTE_MODE fallout pr56605 [PR102146]
>
> The test expects a compare of DImode values, but after the removal of
> PROMOTE_MODE from rs6000/, we get SImode. Adjust the expectations.
> PR target/102146
> * gcc.target/powerpc/pr56605.c: Accept SImode compare operand.
> --- a/gcc/testsuite/gcc.target/powerpc/pr56605.c
> +++ b/gcc/testsuite/gcc.target/powerpc/pr56605.c
> @@ -11,5 +11,5 @@ void foo (short* __restrict sb, int* __restrict ia)
> ia[i] = (int) sb[i];
> }
>
> -/* { dg-final { scan-rtl-dump-times {\(compare:CC
> \((?:and|zero_extend):(?:DI) \((?:sub)?reg:[SD]I} 1 "combine" } } */
> +/* { dg-final { scan-rtl-dump-times {\(compare:CC
> \((?:and|zero_extend):(?:[SD]I) \((?:sub)?reg:[SD]I} 1 "combine" } } */
Ah, a nice small change. This looks fine, thanks! Okay for trunk.
It is fine to allow zero_extend:SI of :SI or :DI, those are invalid RTL,
testcases do not have to test there is no invalid RTL, in general.
Segher
