Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-22 Thread Richard Henderson
On 07/22/2011 06:07 AM, H.J. Lu wrote: > 2011-07-21 H.J. Lu > > * config/i386/i386.c (ix86_option_override_internal): Disallow > MS ABI in x32 mode. > (ix86_init_builtins): Call ix86_init_builtins_va_builtins_abi > only for TARGET_LP64. > (ix86_handle_abi_attribute

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-22 Thread H.J. Lu
On Thu, Jul 21, 2011 at 10:14 PM, H.J. Lu wrote: > On Thu, Jul 21, 2011 at 5:36 PM, H.J. Lu wrote: >> On Thu, Jul 21, 2011 at 4:51 PM, Richard Henderson wrote: >>> On 07/21/2011 04:28 PM, H.J. Lu wrote: On Thu, Jul 21, 2011 at 3:05 PM, Richard Henderson wrote: > On 07/21/2011 03:02 PM,

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-21 Thread H.J. Lu
On Thu, Jul 21, 2011 at 5:36 PM, H.J. Lu wrote: > On Thu, Jul 21, 2011 at 4:51 PM, Richard Henderson wrote: >> On 07/21/2011 04:28 PM, H.J. Lu wrote: >>> On Thu, Jul 21, 2011 at 3:05 PM, Richard Henderson wrote: On 07/21/2011 03:02 PM, H.J. Lu wrote: >       * config/i386/i386.c (functi

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-21 Thread H.J. Lu
On Thu, Jul 21, 2011 at 4:51 PM, Richard Henderson wrote: > On 07/21/2011 04:28 PM, H.J. Lu wrote: >> On Thu, Jul 21, 2011 at 3:05 PM, Richard Henderson wrote: >>> On 07/21/2011 03:02 PM, H.J. Lu wrote:       * config/i386/i386.c (function_value_64): Always return pointers       in Pmod

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-21 Thread Richard Henderson
On 07/21/2011 04:28 PM, H.J. Lu wrote: > On Thu, Jul 21, 2011 at 3:05 PM, Richard Henderson wrote: >> On 07/21/2011 03:02 PM, H.J. Lu wrote: >>> * config/i386/i386.c (function_value_64): Always return pointers >>> in Pmode. >>> (ix86_promote_function_mode): New. >>> (TARGET

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-21 Thread H.J. Lu
On Thu, Jul 21, 2011 at 3:05 PM, Richard Henderson wrote: > On 07/21/2011 03:02 PM, H.J. Lu wrote: >>       * config/i386/i386.c (function_value_64): Always return pointers >>       in Pmode. >>       (ix86_promote_function_mode): New. >>       (TARGET_PROMOTE_FUNCTION_MODE): Likewise. > > Much be

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-21 Thread Richard Henderson
On 07/21/2011 03:02 PM, H.J. Lu wrote: > * config/i386/i386.c (function_value_64): Always return pointers > in Pmode. > (ix86_promote_function_mode): New. > (TARGET_PROMOTE_FUNCTION_MODE): Likewise. Much better, thanks. r~

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-21 Thread H.J. Lu
On Wed, Jul 13, 2011 at 8:37 AM, Richard Henderson wrote: > On 07/13/2011 08:35 AM, H.J. Lu wrote: >> On Wed, Jul 13, 2011 at 8:27 AM, Richard Henderson wrote: >>> On 07/13/2011 07:02 AM, H.J. Lu wrote: Hi Richard, Is my patch OK? >>> >>> No, I don't think it is. >>> >> >> What is

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-13 Thread H.J. Lu
On Wed, Jul 13, 2011 at 8:37 AM, Richard Henderson wrote: > On 07/13/2011 08:35 AM, H.J. Lu wrote: >> On Wed, Jul 13, 2011 at 8:27 AM, Richard Henderson wrote: >>> On 07/13/2011 07:02 AM, H.J. Lu wrote: Hi Richard, Is my patch OK? >>> >>> No, I don't think it is. >>> >> >> What is

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-13 Thread Richard Henderson
On 07/13/2011 08:35 AM, H.J. Lu wrote: > On Wed, Jul 13, 2011 at 8:27 AM, Richard Henderson wrote: >> On 07/13/2011 07:02 AM, H.J. Lu wrote: >>> Hi Richard, >>> >>> Is my patch OK? >> >> No, I don't think it is. >> > > What is your suggestion? Promote the return value. If that means it doesn't

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-13 Thread H.J. Lu
On Wed, Jul 13, 2011 at 8:27 AM, Richard Henderson wrote: > On 07/13/2011 07:02 AM, H.J. Lu wrote: >> Hi Richard, >> >> Is my patch OK? > > No, I don't think it is. > What is your suggestion? -- H.J.

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-13 Thread Richard Henderson
On 07/13/2011 07:02 AM, H.J. Lu wrote: > Hi Richard, > > Is my patch OK? No, I don't think it is. r~

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-13 Thread H.J. Lu
Hi Richard, Is my patch OK? Thanks. H.J. On Sun, Jul 10, 2011 at 6:14 PM, H.J. Lu wrote: > On Sun, Jul 10, 2011 at 5:48 PM, Richard Henderson wrote: >> On 07/10/2011 03:01 PM, H.J. Lu wrote: >>> We only want to promote function parameters passed/returned in register. >>> But  I can't tel

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-13 Thread Uros Bizjak
On Wed, Jul 13, 2011 at 3:17 PM, H.J. Lu wrote: > PING. >> 2011-07-10  H.J. Lu   >> >>        * config/i386/i386.c (ix86_promote_function_mode): New. >>        (TARGET_PROMOTE_FUNCTION_MODE): Likewise. You have discussed this with rth, the final approval should be from him. Uros.

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-13 Thread H.J. Lu
PING. On Sun, Jul 10, 2011 at 12:43 PM, H.J. Lu wrote: > On Sun, Jul 10, 2011 at 7:32 AM, Uros Bizjak wrote: >> On Sat, Jul 9, 2011 at 11:28 PM, H.J. Lu wrote: >> >>> X32 psABI requires promoting pointers to Pmode when passing/returning >>> in registers.  OK for trunk? >>> >>> Thanks. >>> >>> H

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-10 Thread H.J. Lu
On Sun, Jul 10, 2011 at 5:48 PM, Richard Henderson wrote: > On 07/10/2011 03:01 PM, H.J. Lu wrote: >> We only want to promote function parameters passed/returned in register. >> But  I can't tell if a value will be passed in register or memory inside of >> TARGET_FUNCTION_VALUE.  So when FOR_RETUR

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-10 Thread Richard Henderson
On 07/10/2011 03:01 PM, H.J. Lu wrote: > We only want to promote function parameters passed/returned in register. > But I can't tell if a value will be passed in register or memory inside of > TARGET_FUNCTION_VALUE. So when FOR_RETURN is 1, we don't > promote. Even if we don't promote it explicit

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-10 Thread H.J. Lu
On Sun, Jul 10, 2011 at 2:44 PM, Richard Henderson wrote: > On 07/10/2011 12:43 PM, H.J. Lu wrote: >> +/* Pointer function arguments and return values are promoted to Pmode. >> +   If FOR_RETURN is 1, this function must behave in the same way with >> +   regard to function returns as TARGET_FUNCTI

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-10 Thread Richard Henderson
On 07/10/2011 12:43 PM, H.J. Lu wrote: > +/* Pointer function arguments and return values are promoted to Pmode. > + If FOR_RETURN is 1, this function must behave in the same way with > + regard to function returns as TARGET_FUNCTION_VALUE. */ > + > +static enum machine_mode > +ix86_promote_fu

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-10 Thread H.J. Lu
On Sun, Jul 10, 2011 at 7:32 AM, Uros Bizjak wrote: > On Sat, Jul 9, 2011 at 11:28 PM, H.J. Lu wrote: > >> X32 psABI requires promoting pointers to Pmode when passing/returning >> in registers.  OK for trunk? >> >> Thanks. >> >> H.J. >> -- >> 2011-07-09  H.J. Lu   >> >>        * config/i386/i386.

Re: PATCH [3/n] X32: Promote pointers to Pmode

2011-07-10 Thread Uros Bizjak
On Sat, Jul 9, 2011 at 11:28 PM, H.J. Lu wrote: > X32 psABI requires promoting pointers to Pmode when passing/returning > in registers.  OK for trunk? > > Thanks. > > H.J. > -- > 2011-07-09  H.J. Lu   > >        * config/i386/i386.c (ix86_promote_function_mode): New. >        (TARGET_PROMOTE_FUNC

PATCH [3/n] X32: Promote pointers to Pmode

2011-07-09 Thread H.J. Lu
Hi, X32 psABI requires promoting pointers to Pmode when passing/returning in registers. OK for trunk? Thanks. H.J. -- 2011-07-09 H.J. Lu * config/i386/i386.c (ix86_promote_function_mode): New. (TARGET_PROMOTE_FUNCTION_MODE): Likewise. diff --git a/gcc/config/i386/i386.c b/g