On Thu, Jul 21, 2011 at 4:51 PM, Richard Henderson <r...@redhat.com> wrote: > On 07/21/2011 04:28 PM, H.J. Lu wrote: >> On Thu, Jul 21, 2011 at 3:05 PM, Richard Henderson <r...@redhat.com> wrote: >>> On 07/21/2011 03:02 PM, H.J. Lu wrote: >>>> * config/i386/i386.c (function_value_64): Always return pointers >>>> in Pmode. >>>> (ix86_promote_function_mode): New. >>>> (TARGET_PROMOTE_FUNCTION_MODE): Likewise. >>> >>> Much better, thanks. >>> >>> >>> r~ >>> >> >> Also need this patch. Otherwise, I got >> >> FAIL: gcc.target/x86_64/abi/callabi/func-indirect-2a.c (internal compiler >> error) >> FAIL: gcc.target/x86_64/abi/callabi/func-indirect-2a.c (test for excess >> errors) >> FAIL: gcc.target/x86_64/abi/callabi/func-indirect-2b.c (internal compiler >> error) >> FAIL: gcc.target/x86_64/abi/callabi/func-indirect-2b.c (test for excess >> errors) >> >> OK for trunk? > > Hmm. Should we even be running ms_64 callabi tests across pointer sizes > though? >
Good question. I can disable the test. But compiler will still ICE on this input. -- H.J.
