Re: PATCH: PR other/58374: Wrong target check in configure.ac in libvtv

2013-09-10 Thread H.J. Lu
On Tue, Sep 10, 2013 at 8:55 AM, Caroline Tice wrote: > On Tue, Sep 10, 2013 at 3:17 AM, Jakub Jelinek wrote: >> On Mon, Sep 09, 2013 at 01:56:29PM -0700, Caroline Tice wrote: >>> The patch looks good to me, but somebody else needs to approve it. >> >> Why? You are listed as libvtv maintainer, t

Re: PATCH: PR other/58374: Wrong target check in configure.ac in libvtv

2013-09-10 Thread Jakub Jelinek
On Tue, Sep 10, 2013 at 08:55:35AM -0700, Caroline Tice wrote: > Based on the errors you are reporting, my guess is that you did not > configure with --enable-vtable-verifiy. The testsuite in libvtv will I'm not, but it doesn't make sense if you don't configure gcc in certain non-default way, you

Re: PATCH: PR other/58374: Wrong target check in configure.ac in libvtv

2013-09-10 Thread Caroline Tice
I believe I know how to fix this problem; I am in the middle of testing my patch. I should be able to submit the patch either late today or early tomorrow. In the meantime, if this is impacting your ability to make progress, you can configure gcc with --disable-libvtv and that should remove the p

Re: PATCH: PR other/58374: Wrong target check in configure.ac in libvtv

2013-09-10 Thread Caroline Tice
On Tue, Sep 10, 2013 at 3:17 AM, Jakub Jelinek wrote: > On Mon, Sep 09, 2013 at 01:56:29PM -0700, Caroline Tice wrote: >> The patch looks good to me, but somebody else needs to approve it. > > Why? You are listed as libvtv maintainer, the patch is fully contained in > libvtv, thus you can review

Re: PATCH: PR other/58374: Wrong target check in configure.ac in libvtv

2013-09-10 Thread Caroline Tice
On Tue, Sep 10, 2013 at 9:10 AM, Jakub Jelinek wrote: > On Tue, Sep 10, 2013 at 08:55:35AM -0700, Caroline Tice wrote: >> Based on the errors you are reporting, my guess is that you did not >> configure with --enable-vtable-verifiy. The testsuite in libvtv will > > I'm not, but it doesn't make se

Re: PATCH: PR other/58374: Wrong target check in configure.ac in libvtv

2013-09-10 Thread Jakub Jelinek
On Mon, Sep 09, 2013 at 01:56:29PM -0700, Caroline Tice wrote: > The patch looks good to me, but somebody else needs to approve it. Why? You are listed as libvtv maintainer, the patch is fully contained in libvtv, thus you can review it and approve. On an unrelated note, what kind of testing was

Re: PATCH: PR other/58374: Wrong target check in configure.ac in libvtv

2013-09-09 Thread Caroline Tice
The patch looks good to me, but somebody else needs to approve it. -- Caroline Tice cmt...@google.com On Mon, Sep 9, 2013 at 11:48 AM, H.J. Lu wrote: > configure.tgt in libvtv only recognizes canonical targets. This patch > moves the VTV_SUPPORTED check after AC_CANONICAL_SYSTEM for targets > l

PATCH: PR other/58374: Wrong target check in configure.ac in libvtv

2013-09-09 Thread H.J. Lu
configure.tgt in libvtv only recognizes canonical targets. This patch moves the VTV_SUPPORTED check after AC_CANONICAL_SYSTEM for targets like i686-linux or x86_64-linux. OK to install? Thanks. H.J. --- diff --git a/libvtv/ChangeLog b/libvtv/ChangeLog index 20092f4..3c344f9 100644 --- a/libvtv