On Tue, Sep 10, 2013 at 8:55 AM, Caroline Tice <cmt...@google.com> wrote: > On Tue, Sep 10, 2013 at 3:17 AM, Jakub Jelinek <ja...@redhat.com> wrote: >> On Mon, Sep 09, 2013 at 01:56:29PM -0700, Caroline Tice wrote: >>> The patch looks good to me, but somebody else needs to approve it. >> >> Why? You are listed as libvtv maintainer, the patch is fully contained in >> libvtv, thus you can review it and approve. >> > > There was a bit of communication confusion and I originally > misunderstood things. I thought I was the libvtv maintainer, but so > far i have only been proposed (am being proposed?) to the steering > committee to be the libvtv maintainer. Until the steering committee > officially approves that, I am not actually the maintainer, and I do > not have the authority to approve patches.
I saw libvtv Caroline Tice cmt...@google.com in MAINTAINERS and I checked my fix in. > >> On an unrelated note, what kind of testing was performed on libvtv >> testsuite? >> I'm seeing very bad results on both x86_64-linux and i686-linux, like >> === libvtv Summary === >> >> # of expected passes 92 >> # of unexpected failures 44 >> # of unresolved testcases 40 >> >> Many of the errors seem to be related to missing vtv_start_preinit.o >> not being found (why do those actually live in libgcc rather than libvtv?), >> libvtv/Makefile.am has only rules for vtv_start.c etc., but not >> vtv_start_preinit.c. >> > > Actually I performed a lot of testing of this testsuite, but it was > all on my linux x86_64 system. I consistently get it passing all > the tests: > > Based on the errors you are reporting, my guess is that you did not > configure with --enable-vtable-verifiy. The testsuite in libvtv will > not pass without vtable verification enabled. If you DID configure > with --enable-vtable-verify, then please send me the rest of your > configure command so that I can try to reproduce your failures. > I didn't configure GCC with --enable-vtable-verify and libvtv is built. Should we not to build libvtv if vtable-verify is disabled? -- H.J.
