Re: Make possible 'scan-tree-dump' of 'lower_omp_target' mapping kinds

2019-05-28 Thread Jakub Jelinek
On Mon, May 27, 2019 at 11:33:00PM +0200, Thomas Schwinge wrote: > Why exactly are you objecting that the compiler produces useful > intermediate dumps, understandable my machine and human? While still not convinced we need this, if we add it, you are still printing a lot of stuff that is useless

Re: Make possible 'scan-tree-dump' of 'lower_omp_target' mapping kinds

2019-05-27 Thread Thomas Schwinge
Hi! I'm highly annoyed that we're wasting a lot of time arguing about such a minor item. On Mon, 27 May 2019 21:29:13 +0200, Jakub Jelinek wrote: > On Mon, May 27, 2019 at 09:05:06PM +0200, Thomas Schwinge wrote: > > > The arrays are emitted in the *.omplower dump, so I think it is much > > > b

Re: Make possible 'scan-tree-dump' of 'lower_omp_target' mapping kinds

2019-05-27 Thread Jakub Jelinek
On Mon, May 27, 2019 at 09:05:06PM +0200, Thomas Schwinge wrote: > > The arrays are emitted in the *.omplower dump, so I think it is much better > > to scan-tree-dump their content > > That's not feasible in the general case. Why? The arrays have easily parseable names (.omp_data_kinds.N), then

Re: Make possible 'scan-tree-dump' of 'lower_omp_target' mapping kinds

2019-05-27 Thread Thomas Schwinge
If approving this patch, please respond with "Reviewed-by: NAME " so that your effort will be recorded in the commit log, see <https://gcc.gnu.org/wiki/Reviewed-by>. Grüße Thomas >From 30a64c6cf7b8096f27836c62f434eb4bc0ebe966 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Mon, 27 May 2019 18:2

Re: Make possible 'scan-tree-dump' of 'lower_omp_target' mapping kinds

2019-05-27 Thread Jakub Jelinek
On Sun, May 26, 2019 at 06:46:19PM +0200, Thomas Schwinge wrote: > To establish some suitable testsuite coverage for a task that I'm working > on, I need to do 'scan-tree-dump' of 'lower_omp_target' mapping kinds. > Is the attached OK? > > Any suggestions about whether/how to restrict the (effecti

Make possible 'scan-tree-dump' of 'lower_omp_target' mapping kinds

2019-05-26 Thread Thomas Schwinge
espond with "Reviewed-by: NAME " so that your effort will be recorded in the commit log, see <https://gcc.gnu.org/wiki/Reviewed-by>. Grüße Thomas From ba19ef0d5aebf2604e6625d1cca81fc477801966 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Sun, 26 May 2019 18:33:26