Re: Add debugging functions for cp_parser (issue4389045)

2011-04-13 Thread Diego Novillo
On Wed, Apr 13, 2011 at 08:39, Richard Guenther wrote: > On Wed, Apr 13, 2011 at 2:29 PM, Diego Novillo wrote: >> >> I'm not sure if that can be controlled.  When you respond to a hunk on >> Rietveld, it creates the quote automatically.  Maybe there is a way of >> increasing the scope of the quot

Re: Add debugging functions for cp_parser (issue4389045)

2011-04-13 Thread Richard Guenther
On Wed, Apr 13, 2011 at 2:29 PM, Diego Novillo wrote: > On Wed, Apr 13, 2011 at 05:25, Richard Guenther > wrote: >> On Wed, Apr 13, 2011 at 2:02 AM,   wrote: >>> One oddity, otherwise LGTM. >>> >>> >>> http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c >>> File gcc/cp/parser.c (right):

Re: Add debugging functions for cp_parser (issue4389045)

2011-04-13 Thread Diego Novillo
On Wed, Apr 13, 2011 at 05:25, Richard Guenther wrote: > On Wed, Apr 13, 2011 at 2:02 AM,   wrote: >> One oddity, otherwise LGTM. >> >> >> http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c >> File gcc/cp/parser.c (right): >> >> http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.

Re: Add debugging functions for cp_parser (issue4389045)

2011-04-13 Thread Richard Guenther
On Wed, Apr 13, 2011 at 2:02 AM, wrote: > One oddity, otherwise LGTM. > > > http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c > File gcc/cp/parser.c (right): > > http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c#newcode375 > gcc/cp/parser.c:375: if (flag) > This code will ne

Re: Add debugging functions for cp_parser (issue4389045)

2011-04-12 Thread Diego Novillo
On Tue, Apr 12, 2011 at 20:02, wrote: > One oddity, otherwise LGTM. > > > http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c > File gcc/cp/parser.c (right): > > http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c#newcode375 > gcc/cp/parser.c:375: if (flag) > This code will neve

Re: Add debugging functions for cp_parser (issue4389045)

2011-04-12 Thread crowl
One oddity, otherwise LGTM. http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c File gcc/cp/parser.c (right): http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c#newcode375 gcc/cp/parser.c:375: if (flag) This code will never print "false", so why have it? http://codereview.ap

Add debugging functions for cp_parser (issue4389045)

2011-04-11 Thread Diego Novillo
This patch adds a debugging function to print the state of a cp_parser instance. It prints all the status fields in the structure and a window of 20 tokens around the current token. This patch is against the pph branch, but it should apply almost cleanly to trunk. OK for mainline? Diego. cp/