On Wed, Apr 13, 2011 at 05:25, Richard Guenther
<richard.guent...@gmail.com> wrote:
> On Wed, Apr 13, 2011 at 2:02 AM,  <cr...@google.com> wrote:
>> One oddity, otherwise LGTM.
>>
>>
>> http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c
>> File gcc/cp/parser.c (right):
>>
>> http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c#newcode375
>> gcc/cp/parser.c:375: if (flag)
>> This code will never print "false", so why have it?
>
> Can you quote the piece of the patch you are commenting on?

I'm not sure if that can be controlled.  When you respond to a hunk on
Rietveld, it creates the quote automatically.  Maybe there is a way of
increasing the scope of the quote.  I'll ask.

Diego.

Reply via email to