Re: [PING] Add const char* constructors for exception classes in

2014-05-11 Thread Oleg Endo
On 02 May 2014, at 17:57, Jonathan Wakely wrote: > On 1 May 2014 17:18, Oleg Endo wrote: >> Jonathan, >> >> now that we're in stage 1 again, I'd like to revive the issue below. Do >> you have any particular plans? How should we proceed? > > Hi Oleg, sorry for letting the thread die in Januar

Re: [PING] Re: Add const char* constructors for exception classes in

2014-05-02 Thread Jonathan Wakely
On 1 May 2014 17:18, Oleg Endo wrote: > Jonathan, > > now that we're in stage 1 again, I'd like to revive the issue below. Do > you have any particular plans? How should we proceed? Hi Oleg, sorry for letting the thread die in January. We will definitely want to deal with the missing constructo

Re: [PING] Re: Add const char* constructors for exception classes in

2014-05-01 Thread Oleg Endo
Jonathan, now that we're in stage 1 again, I'd like to revive the issue below. Do you have any particular plans? How should we proceed? Cheers, Oleg On Wed, 2014-01-29 at 23:45 +0100, Oleg Endo wrote: > On Wed, 2014-01-29 at 21:38 +, Jonathan Wakely wrote: > > On 29 January 2014 21:17, Ole

Re: [PING] Re: Add const char* constructors for exception classes in

2014-01-29 Thread Oleg Endo
On Wed, 2014-01-29 at 21:38 +, Jonathan Wakely wrote: > On 29 January 2014 21:17, Oleg Endo wrote: > > My original intention was to eliminate code bloat when doing something > > like throw std::logic_error ("cold coffee"); > > If the const char* overloads are inlined it will emit code to const

Re: [PING] Re: Add const char* constructors for exception classes in

2014-01-29 Thread Jonathan Wakely
On 29 January 2014 21:17, Oleg Endo wrote: > My original intention was to eliminate code bloat when doing something > like throw std::logic_error ("cold coffee"); > If the const char* overloads are inlined it will emit code to construct > an std::string from const char* in user code where the exce

Re: [PING] Re: Add const char* constructors for exception classes in

2014-01-29 Thread Oleg Endo
On Wed, 2014-01-29 at 15:21 +, Jonathan Wakely wrote: > On 26/01/14 15:15 +0100, Oleg Endo wrote: > >> Files in libstdc++-v3/src/c++98/ seem to be never compiled with C++11. > >> Thus I can think of two options: > >> 1) Add const char* ctors for C++98 and C++11. > >> 2) Add #ifdef'ed declaratio

Re: [PING] Re: Add const char* constructors for exception classes in

2014-01-29 Thread Jonathan Wakely
On 26/01/14 15:15 +0100, Oleg Endo wrote: Files in libstdc++-v3/src/c++98/ seem to be never compiled with C++11. Thus I can think of two options: 1) Add const char* ctors for C++98 and C++11. 2) Add #ifdef'ed declarations to libstdc++-v3/include/std/stdexcept and add a new file libstdc++-v3/src/c

[PING] Re: Add const char* constructors for exception classes in

2014-01-26 Thread Oleg Endo
Ping. The patch in question is here: http://gcc.gnu.org/ml/gcc-patches/2013-12/msg01688.html On Thu, 2013-12-19 at 16:28 +0100, Oleg Endo wrote: > On Thu, 2013-12-19 at 01:19 +, Jonathan Wakely wrote: > > On 19 December 2013 00:10, Oleg Endo wrote: > > > Hello, > > > > > > When writing code s

Re: Add const char* constructors for exception classes in

2013-12-19 Thread Oleg Endo
On Thu, 2013-12-19 at 01:19 +, Jonathan Wakely wrote: > On 19 December 2013 00:10, Oleg Endo wrote: > > Hello, > > > > When writing code such as > > ... > > throw std::logic_error ("cold coffee"); > > ... > > currently the construction of std::string happens in the code that > > throws the ex

Re: Add const char* constructors for exception classes in

2013-12-18 Thread Jonathan Wakely
On 19 December 2013 00:10, Oleg Endo wrote: > Hello, > > When writing code such as > ... > throw std::logic_error ("cold coffee"); > ... > currently the construction of std::string happens in the code that > throws the exception, which results in code bloat. Implementing the > const char* constr

Add const char* constructors for exception classes in

2013-12-18 Thread Oleg Endo
Hello, When writing code such as ... throw std::logic_error ("cold coffee"); ... currently the construction of std::string happens in the code that throws the exception, which results in code bloat. Implementing the const char* constructors as defined by C++11 fixes the issue. I'm not sure whet