Re: [v3 PATCH] Implement 2801, Default-constructibility of unique_ptr.

2017-01-04 Thread Jonathan Wakely
On 29/12/16 22:10 +0200, Ville Voutilainen wrote: On 29 December 2016 at 21:57, Ville Voutilainen wrote: Instead of repeating this condition half a dozen times, we could put it in the __uniq_ptr_impl class template and reuse it, as in the attached patch (and similarly for the unique_ptr special

Re: [v3 PATCH] Implement 2801, Default-constructibility of unique_ptr.

2016-12-29 Thread Ville Voutilainen
On 29 December 2016 at 21:57, Ville Voutilainen wrote: >> Instead of repeating this condition half a dozen times, we could put >> it in the __uniq_ptr_impl class template and reuse it, as in the >> attached patch (and similarly for the unique_ptr specialization). >> What do you think? > > It needs

Re: [v3 PATCH] Implement 2801, Default-constructibility of unique_ptr.

2016-12-29 Thread Ville Voutilainen
On 22 December 2016 at 19:11, Jonathan Wakely wrote: >> /// Default constructor, creates a unique_ptr that owns nothing. >> + template > + typename enable_if< >> + __and_<__not_>, >> +is_default_constructible<_Up>>::value, >> +

Re: [v3 PATCH] Implement 2801, Default-constructibility of unique_ptr.

2016-12-22 Thread Jonathan Wakely
On 20/12/16 22:52 +0200, Ville Voutilainen wrote: diff --git a/libstdc++-v3/include/bits/unique_ptr.h b/libstdc++-v3/include/bits/unique_ptr.h index 56e6ec0..63dff37 100644 --- a/libstdc++-v3/include/bits/unique_ptr.h +++ b/libstdc++-v3/include/bits/unique_ptr.h @@ -175,10 +175,14 @@ _GLIBCXX_BE

[v3 PATCH] Implement 2801, Default-constructibility of unique_ptr.

2016-12-20 Thread Ville Voutilainen
Tested on Linux-x64. The issue doesn't have a proposed resolution yet, so we can certainly wait with this, but I have an inkling that this implementation is what the proposed resolution must say. :) 2016-12-20 Ville Voutilainen Implement 2801, Default-constructibility of unique_ptr. *