Re: [rs6000] fix mffsl emulation

2020-05-26 Thread Alexandre Oliva
On Apr 28, 2020, Segher Boessenkool wrote: > Okay for trunk with such tweaks. Thank you! Also okay for the 9 branch, > after waiting to see if any fallout appears. Thanks, I've just pushed it to the gcc-9 branch. -- Alexandre Oliva, freedom fighterhe/himhttps://FSFLA.org/blogs/lxo/ F

Re: [rs6000] fix mffsl emulation

2020-04-28 Thread Segher Boessenkool
On Tue, Apr 28, 2020 at 07:15:58PM -0300, Alexandre Oliva wrote: > On Apr 28, 2020, Segher Boessenkool wrote: > > > s/mmfl/mffs/ > > s/mmfs/mffs/ > > s/mmsl/mffsl/ > > Oh, my, looks like I missed some mispellings of ffmls :-P It helps to read the mnemonics as the full name -- the Power mnemonic

Re: [rs6000] fix mffsl emulation

2020-04-28 Thread Alexandre Oliva
ay for the 9 branch, > after waiting to see if any fallout appears. Thanks, here's what I'm checking in... [rs6000] fix mffsl emulation From: Alexandre Oliva The emulation of mffsl with mffs, used when !TARGET_P9_MISC, is going through the motions, but not storing the result in

Re: [rs6000] fix mffsl emulation

2020-04-28 Thread Segher Boessenkool
Hi! On Tue, Apr 28, 2020 at 12:25:04AM -0300, Alexandre Oliva wrote: > On Apr 24, 2020, Segher Boessenkool wrote: > > >> > since all the top bits are zeros always, it will always be a subnormal > >> > number, so all comparisons will work as expected / wanted. > >> > >> *nod*, as long as there's

Re: [rs6000] fix mffsl emulation

2020-04-27 Thread Alexandre Oliva
d test_mffsl.c with and without -mpower9-misc. Regstrapping on ppc64le-linux-gnu. Ok to install? [rs6000] fix mffsl emulation From: Alexandre Oliva The emulation of mffsl with mffs, used when !TARGET_P9_MISC, is going through the motions, but not storing the result in the given operands[0]; it

Re: [rs6000] fix mffsl emulation

2020-04-24 Thread Segher Boessenkool
Hi! On Fri, Apr 24, 2020 at 04:52:46AM -0300, Alexandre Oliva wrote: > On Apr 23, 2020, Segher Boessenkool wrote: > > On Thu, Apr 23, 2020 at 05:08:55AM -0300, Alexandre Oliva wrote: > >> I wasn't sure simplify_gen_subreg might possibly emit any code in > >> obscure cases, > > > It never does, i

Re: [rs6000] fix mffsl emulation

2020-04-24 Thread Alexandre Oliva
Hello, Segher, On Apr 23, 2020, Segher Boessenkool wrote: > On Thu, Apr 23, 2020 at 05:08:55AM -0300, Alexandre Oliva wrote: >> I wasn't sure simplify_gen_subreg might possibly emit any code in >> obscure cases, > It never does, it just returns an RTX. Where would it emit the insns to? I'm p

Re: [rs6000] fix mffsl emulation

2020-04-23 Thread Segher Boessenkool
Hi! On Thu, Apr 23, 2020 at 05:08:55AM -0300, Alexandre Oliva wrote: > The emulation of mffsl with mffs, used when !TARGET_P9_MISC, is going > through the motions, but not storing the result in the given > operands[0]; it rather modifies operands[0] without effect. Heh, oops. > It also > creates

[rs6000] fix mffsl emulation

2020-04-23 Thread Alexandre Oliva
The emulation of mffsl with mffs, used when !TARGET_P9_MISC, is going through the motions, but not storing the result in the given operands[0]; it rather modifies operands[0] without effect. It also creates a DImode pseudo that it doesn't use, a DFmode pseudo that's unnecessary AFAICT, and it's