Re: [pph] Add header files to pph.map (issue4639073)

2011-06-27 Thread Lawrence Crowl
On 6/27/11, Gabriel Charette wrote: > On Jun 27, 2011 Diego Novillo wrote: > > On Jun 27, 2011 Gabriel Charette wrote: > > > Couldn't we have headers look for their corresponding .pph > > > file by default when -fpph-map is on? (especially since > > > pph.map is only temporary for the implementa

Re: [pph] Add header files to pph.map (issue4639073)

2011-06-27 Thread Gabriel Charette
On Mon, Jun 27, 2011 at 10:18 AM, Diego Novillo wrote: > On Mon, Jun 27, 2011 at 13:13, Gabriel Charette wrote: >> On Mon, Jun 27, 2011 at 10:06 AM, Diego Novillo wrote: >>> On Mon, Jun 27, 2011 at 13:01, Gabriel Charette wrote: Couldn't we have headers look for their corresponding .pph fi

Re: [pph] Add header files to pph.map (issue4639073)

2011-06-27 Thread Diego Novillo
On Mon, Jun 27, 2011 at 13:13, Gabriel Charette wrote: > On Mon, Jun 27, 2011 at 10:06 AM, Diego Novillo wrote: >> On Mon, Jun 27, 2011 at 13:01, Gabriel Charette wrote: >>> Couldn't we have headers look for their corresponding .pph file by >>> default when -fpph-map is on? (especially since pph

Re: [pph] Add header files to pph.map (issue4639073)

2011-06-27 Thread Gabriel Charette
On Mon, Jun 27, 2011 at 10:06 AM, Diego Novillo wrote: > On Mon, Jun 27, 2011 at 13:01, Gabriel Charette wrote: >> Couldn't we have headers look for their corresponding .pph file by >> default when -fpph-map is on? (especially since pph.map is only >> temporary for the implementation phase) > > T

Re: [pph] Add header files to pph.map (issue4639073)

2011-06-27 Thread Diego Novillo
On Mon, Jun 27, 2011 at 13:01, Gabriel Charette wrote: > Couldn't we have headers look for their corresponding .pph file by > default when -fpph-map is on? (especially since pph.map is only > temporary for the implementation phase) The problem is with headers that include other headers. We want

Re: [pph] Add header files to pph.map (issue4639073)

2011-06-27 Thread Gabriel Charette
Couldn't we have headers look for their corresponding .pph file by default when -fpph-map is on? (especially since pph.map is only temporary for the implementation phase) I would see it like this: if -fpph-map is not NULL: look for mapping in file if not found: look for default mapping (i.

[pph] Add header files to pph.map (issue4639073)

2011-06-27 Thread Diego Novillo
When I added these tests, I forgot to add them to pph.map, so the header files were being generated into an image, but not used in the second compilation. Most of the failures are in the form of different asm output. There is one new ICE, though. Committed to branch. Diego. * g++.dg/