> On 7 Jan 2020, at 18:21, Richard Sandiford wrote:
>> * gcc.target/aarch64/stack-check-alloca.h: Remove
>> #include alloca.h. #define alloca __builtin_alloca
>> instead.
> OK, thanks.
Great, thanks Richard!
Olivier Hainque writes:
> Hi Andrew,
>
>> On 6 Jan 2020, at 23:24, Andrew Pinski wrote:
>> Just one small suggestion:
>
> Sure
>
>> Instead of:
>> - char* pStr = alloca(SIZE);
>> + char* pStr = __builtin_alloca(SIZE);
>>
>> Why not just do:
>> -#include
>> +#define alloca __builtin_alloca
>
>
Hi Andrew,
> On 6 Jan 2020, at 23:24, Andrew Pinski wrote:
> Just one small suggestion:
Sure
> Instead of:
> - char* pStr = alloca(SIZE);
> + char* pStr = __builtin_alloca(SIZE);
>
> Why not just do:
> -#include
> +#define alloca __builtin_alloca
Yes, good idea.
Revised patch attached, wh
On Mon, Jan 6, 2020 at 2:18 PM Olivier Hainque wrote:
>
> Hello,
>
> The aarch64 testsuite features a few tests for
> the stack-clash-protection facility, all using "alloca"
> after an #include .
>
> The use of alloca.h causes the tests to fail on
> target systems not providing that header, such a
Hello,
The aarch64 testsuite features a few tests for
the stack-clash-protection facility, all using "alloca"
after an #include .
The use of alloca.h causes the tests to fail on
target systems not providing that header, such as some
variants of VxWorks.
My understanding is that the tests really
