Olivier Hainque <hain...@adacore.com> writes:
> Hi Andrew,
>
>> On 6 Jan 2020, at 23:24, Andrew Pinski <pins...@gmail.com> wrote:
>> Just one small suggestion:
>
> Sure
>
>> Instead of:
>> - char* pStr = alloca(SIZE);
>> + char* pStr = __builtin_alloca(SIZE);
>>
>> Why not just do:
>> -#include <alloca.h>
>> +#define alloca __builtin_alloca
>
> Yes, good idea.
>
> Revised patch attached, where I also added a comment
> explaining why we are doing this.
>
> Re-tested on aarch64-linux.
>
> Is this one ok ?
>
> Thanks,
>
> Olivier
>
> 2020-01-06 Olivier Hainque <hain...@adacore.com>
> Alexandre Oliva <ol...@adacore.com>
>
> * gcc.target/aarch64/stack-check-alloca.h: Remove
> #include alloca.h. #define alloca __builtin_alloca
> instead.
> * gcc.target/aarch64/stack-check-alloca-1.c: Add
> { dg-require-effective-target alloca }.
> * gcc.target/aarch64/stack-check-alloca-2.c: Likewise.
> * gcc.target/aarch64/stack-check-alloca-3.c: Likewise.
> * gcc.target/aarch64/stack-check-alloca-4.c: Likewise.
> * gcc.target/aarch64/stack-check-alloca-5.c: Likewise.
> * gcc.target/aarch64/stack-check-alloca-6.c: Likewise.
> * gcc.target/aarch64/stack-check-alloca-7.c: Likewise.
> * gcc.target/aarch64/stack-check-alloca-8.c: Likewise.
> * gcc.target/aarch64/stack-check-alloca-9.c: Likewise.
> * gcc.target/aarch64/stack-check-alloca-10.c: Likewise.
OK, thanks.
Richard
