[patch, libgfortran] PR56743 Namelist bug with comment and no blank

2015-04-17 Thread Jerry DeLisle
The attached patch works by adding the comment character to the set of characters treated as separators. This works because a namelist comment abstractly can be though of as equivalent to an end of line character. For namelist the '!' character is already handled in the 'eat_separators' helper

Re: [patch, libgfortran] PR56743 Namelist bug with comment and no blank

2013-05-05 Thread Janne Blomqvist
On Sun, May 5, 2013 at 8:25 AM, Jerry DeLisle wrote: > I don't see much point in issuing a warning if we accept it. I can just as > easily make it an error with something like "A value separator is required > before a namelist comment" and be done with trying to second guess whether > someone is

Re: [patch, libgfortran] PR56743 Namelist bug with comment and no blank

2013-05-05 Thread Jerry DeLisle
On 05/05/2013 05:47 AM, Steve Kargl wrote: > On Sat, May 04, 2013 at 10:25:19PM -0700, Jerry DeLisle wrote: >> On 05/04/2013 06:30 PM, Steve Kargl wrote: >>> On Sat, May 04, 2013 at 05:13:51PM -0700, Jerry DeLisle wrote: CASE_SEPARATORS:/* Not a repeat count. */ case

Re: [patch, libgfortran] PR56743 Namelist bug with comment and no blank

2013-05-05 Thread Steve Kargl
On Sat, May 04, 2013 at 10:25:19PM -0700, Jerry DeLisle wrote: > On 05/04/2013 06:30 PM, Steve Kargl wrote: > > On Sat, May 04, 2013 at 05:13:51PM -0700, Jerry DeLisle wrote: > >> > >>CASE_SEPARATORS:/* Not a repeat count. */ > >>case EOF: > >> + case '!': > > > > if (c =

Re: [patch, libgfortran] PR56743 Namelist bug with comment and no blank

2013-05-05 Thread Tobias Burnus
Janus Weil wrote: 2013/5/5 Jerry DeLisle : On 05/04/2013 06:30 PM, Steve Kargl wrote: On Sat, May 04, 2013 at 05:13:51PM -0700, Jerry DeLisle wrote: CASE_SEPARATORS:/* Not a repeat count. */ case EOF: +case '!': if (c == '!') gfc_warning("GNU Fortran

Re: [patch, libgfortran] PR56743 Namelist bug with comment and no blank

2013-05-05 Thread Janus Weil
2013/5/5 Jerry DeLisle : > On 05/04/2013 06:30 PM, Steve Kargl wrote: >> On Sat, May 04, 2013 at 05:13:51PM -0700, Jerry DeLisle wrote: >>> >>> CASE_SEPARATORS:/* Not a repeat count. */ >>> case EOF: >>> +case '!': >> >> if (c == '!') >> gfc_warning("GNU Fortra

Re: [patch, libgfortran] PR56743 Namelist bug with comment and no blank

2013-05-04 Thread Jerry DeLisle
On 05/04/2013 06:30 PM, Steve Kargl wrote: > On Sat, May 04, 2013 at 05:13:51PM -0700, Jerry DeLisle wrote: >> >> CASE_SEPARATORS:/* Not a repeat count. */ >> case EOF: >> +case '!': > > if (c == '!') > gfc_warning("GNU Fortran extension: accepting a possibl

Re: [patch, libgfortran] PR56743 Namelist bug with comment and no blank

2013-05-04 Thread Steve Kargl
On Sat, May 04, 2013 at 05:13:51PM -0700, Jerry DeLisle wrote: > > CASE_SEPARATORS:/* Not a repeat count. */ > case EOF: > + case '!': if (c == '!') gfc_warning("GNU Fortran extension: accepting a possibly " "corrupted namelist"); >

Re: [patch, libgfortran] PR56743 Namelist bug with comment and no blank

2013-05-04 Thread Jerry DeLisle
On 05/04/2013 05:13 PM, Jerry DeLisle wrote: > The attached patch resolves this PR by treating '!', the Fortran comment mark, > as a valid separator between values. Thus, when encountered while reading a > value, the read is ended normally with whatever value was encountered. This > is > an exte

[patch, libgfortran] PR56743 Namelist bug with comment and no blank

2013-05-04 Thread Jerry DeLisle
The attached patch resolves this PR by treating '!', the Fortran comment mark, as a valid separator between values. Thus, when encountered while reading a value, the read is ended normally with whatever value was encountered. This is an extension beyond the Standards which require a separator bef