Re: [committed] libstdc++: Fix constexpr functions in

2023-03-31 Thread Jonathan Wakely via Gcc-patches
On Fri, 31 Mar 2023 at 12:06, Jonathan Wakely wrote: > > On Thu, 30 Mar 2023 at 17:01, Daniel Krügler wrote: > > > > Am Do., 30. März 2023 um 18:00 Uhr schrieb Jonathan Wakely via > > Libstdc++ : > > > > > [..] > > > > > > In fact, thinking about P2641 some more, I might revert this change. > > > I

Re: [committed] libstdc++: Fix constexpr functions in

2023-03-31 Thread Jonathan Wakely via Gcc-patches
On Thu, 30 Mar 2023 at 17:01, Daniel Krügler wrote: > > Am Do., 30. März 2023 um 18:00 Uhr schrieb Jonathan Wakely via > Libstdc++ : > > > [..] > > > > In fact, thinking about P2641 some more, I might revert this change. > > Instead of adding an extra bool member to support constexpr, I think > > I

Re: [committed] libstdc++: Fix constexpr functions in

2023-03-30 Thread Daniel Krügler via Gcc-patches
Am Do., 30. März 2023 um 18:00 Uhr schrieb Jonathan Wakely via Libstdc++ : > [..] > > In fact, thinking about P2641 some more, I might revert this change. > Instead of adding an extra bool member to support constexpr, I think > I'll just remove the 'constexpr' keywords from basic_endpoint for now,

Re: [committed] libstdc++: Fix constexpr functions in

2023-03-30 Thread Jonathan Wakely via Gcc-patches
On Thu, 30 Mar 2023 at 15:44, Jonathan Wakely wrote: > > On Thu, 30 Mar 2023 at 00:40, Jonathan Wakely via Libstdc++ > wrote: > > > > Tested powerpc64le-linux. Pushed to trunk. > > > > -- >8 -- > > > > Change ip::basic_endpoint to work in constant expressions, but only for > > C++20 and later (due

Re: [committed] libstdc++: Fix constexpr functions in

2023-03-30 Thread Jonathan Wakely via Gcc-patches
On Thu, 30 Mar 2023 at 00:40, Jonathan Wakely via Libstdc++ wrote: > > Tested powerpc64le-linux. Pushed to trunk. > > -- >8 -- > > Change ip::basic_endpoint to work in constant expressions, but only for > C++20 and later (due to the use of a union, which cannot change active > member in constexpr

[committed] libstdc++: Fix constexpr functions in

2023-03-29 Thread Jonathan Wakely via Gcc-patches
Tested powerpc64le-linux. Pushed to trunk. -- >8 -- Change ip::basic_endpoint to work in constant expressions, but only for C++20 and later (due to the use of a union, which cannot change active member in constexpr evaluation until C++20). During constant evaluation we cannot inspect the common