Re: [c++ PATCH] PR c++/80682

2017-05-10 Thread Nathan Sidwell
On 05/10/2017 01:13 PM, Richard Biener wrote: On May 10, 2017 6:36:20 PM GMT+02:00, Nathan Sidwell wrote: On 05/10/2017 10:21 AM, Ville Voutilainen wrote: IIUC backports have to fix a regression. So you'll need to convince the release maintainer. From a C++ POV you're approved. Wrong-cod

Re: [c++ PATCH] PR c++/80682

2017-05-10 Thread Richard Biener
On May 10, 2017 6:36:20 PM GMT+02:00, Nathan Sidwell wrote: >On 05/10/2017 10:21 AM, Ville Voutilainen wrote: >> On 10 May 2017 at 14:40, Nathan Sidwell wrote: > >> >> I appreciate that, but given that I operate under Write-After >Approval, I need >> more than a no-objection, I will need an actu

Re: [c++ PATCH] PR c++/80682

2017-05-10 Thread Nathan Sidwell
On 05/10/2017 10:21 AM, Ville Voutilainen wrote: On 10 May 2017 at 14:40, Nathan Sidwell wrote: I appreciate that, but given that I operate under Write-After Approval, I need more than a no-objection, I will need an actual ok from a maintainer. :) IIUC backports have to fix a regression.

Re: [c++ PATCH] PR c++/80682

2017-05-10 Thread Ville Voutilainen
On 10 May 2017 at 14:40, Nathan Sidwell wrote: >>> Full testsuite run is clean. Is it ok to backport this change to >>> gcc-6? (And gcc-7, too) >> >> >> ..and gcc-5. Backporting everywhere allows library implementations >> including libc++ to >> just use the intrinsic, without using std::is_constr

Re: [c++ PATCH] PR c++/80682

2017-05-10 Thread Nathan Sidwell
On 05/10/2017 05:37 AM, Ville Voutilainen wrote: On 10 May 2017 at 09:57, Ville Voutilainen wrote: Full testsuite run is clean. Is it ok to backport this change to gcc-6? (And gcc-7, too) ..and gcc-5. Backporting everywhere allows library implementations including libc++ to just use the in

Re: [c++ PATCH] PR c++/80682

2017-05-10 Thread Ville Voutilainen
On 10 May 2017 at 09:57, Ville Voutilainen wrote: > On 9 May 2017 at 17:14, Nathan Sidwell wrote: >> On 05/09/2017 08:06 AM, Ville Voutilainen wrote: >>> >>> Tested on Linux-x64, not tested with the full suite yet. >>> >>> 2017-05-09 Ville Voutilainen >>> >>> gcc/ >>> >>> PR c++/8068

Re: [c++ PATCH] PR c++/80682

2017-05-09 Thread Ville Voutilainen
On 9 May 2017 at 17:14, Nathan Sidwell wrote: > On 05/09/2017 08:06 AM, Ville Voutilainen wrote: >> >> Tested on Linux-x64, not tested with the full suite yet. >> >> 2017-05-09 Ville Voutilainen >> >> gcc/ >> >> PR c++/80682 >> * cp/method.c (is_trivially_xible): Reject void type

Re: [c++ PATCH] PR c++/80682

2017-05-09 Thread Nathan Sidwell
On 05/09/2017 08:06 AM, Ville Voutilainen wrote: Tested on Linux-x64, not tested with the full suite yet. 2017-05-09 Ville Voutilainen gcc/ PR c++/80682 * cp/method.c (is_trivially_xible): Reject void types. testsuite/ PR c++/80682 * g++.dg/ext/is_trivially_c

Re: [c++ PATCH] PR c++/80682

2017-05-09 Thread Ville Voutilainen
On 9 May 2017 at 16:25, Jakub Jelinek wrote: >> >> 2017-05-09 Ville Voutilainen >> >> >> >>gcc/ >> >> >> >>PR c++/80682 >> >>* cp/method.c (is_trivially_xible): Reject void types. > > No cp/ in cp/ChangeLog entries. So perhaps 2017-05-09 Ville Voutilainen cp/ PR c++/8

Re: [c++ PATCH] PR c++/80682

2017-05-09 Thread Jakub Jelinek
On Tue, May 09, 2017 at 04:17:07PM +0300, Ville Voutilainen wrote: > On 9 May 2017 at 16:12, Marc Glisse wrote: > > On Tue, 9 May 2017, Ville Voutilainen wrote: > > > >> Tested on Linux-x64, not tested with the full suite yet. > >> > >> 2017-05-09 Ville Voutilainen > >> > >>gcc/ > >> > >>

Re: [c++ PATCH] PR c++/80682

2017-05-09 Thread Ville Voutilainen
On 9 May 2017 at 16:12, Marc Glisse wrote: > On Tue, 9 May 2017, Ville Voutilainen wrote: > >> Tested on Linux-x64, not tested with the full suite yet. >> >> 2017-05-09 Ville Voutilainen >> >>gcc/ >> >>PR c++/80682 >>* cp/method.c (is_trivially_xible): Reject void types. >> >>te

Re: [c++ PATCH] PR c++/80682

2017-05-09 Thread Marc Glisse
On Tue, 9 May 2017, Ville Voutilainen wrote: Tested on Linux-x64, not tested with the full suite yet. 2017-05-09 Ville Voutilainen gcc/ PR c++/80682 * cp/method.c (is_trivially_xible): Reject void types. testsuite/ PR c++/80682 * g++.dg/ext/is_trivially_constructible1.C

[c++ PATCH] PR c++/80682

2017-05-09 Thread Ville Voutilainen
Tested on Linux-x64, not tested with the full suite yet. 2017-05-09 Ville Voutilainen gcc/ PR c++/80682 * cp/method.c (is_trivially_xible): Reject void types. testsuite/ PR c++/80682 * g++.dg/ext/is_trivially_constructible1.C: Add tests for void target. diff --git a/