Re: [RFC 1/2] libbacktrace: add FDPIC support

2024-07-17 Thread Gerald Pfeifer
On Mon, 15 Jul 2024, Ian Lance Taylor wrote: > Thanks for testing. Committed to mainline with this ChangeLog entry: > > * internal.h: If FDPIC, #include and/or . > (libbacktrace_using_fdpic): Define. > (struct libbacktrace_base_address): Define. > (libbacktrace_add_base): Define. > (backtrace_dw

Re: [RFC 1/2] libbacktrace: add FDPIC support

2024-07-16 Thread Ian Lance Taylor
On Tue, Jul 16, 2024 at 5:41 PM David Edelsohn wrote: > > I believe that this patch broke bootstrap on AIX: > > /nasfarm/edelsohn/src/src/libbacktrace/xcoff.c: In function 'xcoff_add': > /nasfarm/edelsohn/src/src/libbacktrace/xcoff.c:1309:40: error: incompatible > type for argument 2 of 'backtrac

Re: [RFC 1/2] libbacktrace: add FDPIC support

2024-07-16 Thread David Edelsohn
Hi, Ian I believe that this patch broke bootstrap on AIX: /nasfarm/edelsohn/src/src/libbacktrace/xcoff.c: In function 'xcoff_add': /nasfarm/edelsohn/src/src/libbacktrace/xcoff.c:1309:40: error: incompatible type for argument 2 of 'backtrace_dwarf_add' 1309 | if (!backtrace_dwarf_add (state

Re: [RFC 1/2] libbacktrace: add FDPIC support

2024-07-15 Thread Ian Lance Taylor
On Mon, Jul 15, 2024 at 3:17 PM Max Filippov wrote: > > On Mon, Jul 15, 2024 at 10:21:18AM -0700, Ian Lance Taylor wrote: > > Can you see whether this patch works for FDPIC support? This is based > > on your patch but has various changes. Thanks. > > Yes, it is working. Thanks for testing. Com

Re: [RFC 1/2] libbacktrace: add FDPIC support

2024-07-15 Thread Max Filippov
On Mon, Jul 15, 2024 at 10:21:18AM -0700, Ian Lance Taylor wrote: > Can you see whether this patch works for FDPIC support? This is based > on your patch but has various changes. Thanks. Yes, it is working. -- Thanks. -- Max

Re: [RFC 1/2] libbacktrace: add FDPIC support

2024-07-15 Thread Ian Lance Taylor
Can you see whether this patch works for FDPIC support? This is based on your patch but has various changes. Thanks. Ian diff --git a/libbacktrace/dwarf.c b/libbacktrace/dwarf.c index cc36a0a2990..96ffc4cc481 100644 --- a/libbacktrace/dwarf.c +++ b/libbacktrace/dwarf.c @@ -388,8 +388,8 @@ struct

Re: [RFC 1/2] libbacktrace: add FDPIC support

2024-07-15 Thread Ian Lance Taylor
On Sat, Jul 13, 2024 at 7:52 PM Max Filippov wrote: > > On Wed, Jul 10, 2024 at 12:49 PM Ian Lance Taylor wrote: > > On Sun, May 26, 2024 at 11:51 PM Max Filippov wrote: > > > diff --git a/libbacktrace/internal.h b/libbacktrace/internal.h > > > index 4fa0af8cb6c9..456911166026 100644 > > > --- a

Re: [RFC 1/2] libbacktrace: add FDPIC support

2024-07-13 Thread Max Filippov
On Wed, Jul 10, 2024 at 12:49 PM Ian Lance Taylor wrote: > On Sun, May 26, 2024 at 11:51 PM Max Filippov wrote: > > diff --git a/libbacktrace/internal.h b/libbacktrace/internal.h > > index 4fa0af8cb6c9..456911166026 100644 > > --- a/libbacktrace/internal.h > > +++ b/libbacktrace/internal.h > > @@

Re: [RFC 1/2] libbacktrace: add FDPIC support

2024-07-10 Thread Ian Lance Taylor
On Sun, May 26, 2024 at 11:51 PM Max Filippov wrote: > > diff --git a/libbacktrace/internal.h b/libbacktrace/internal.h > index 4fa0af8cb6c9..456911166026 100644 > --- a/libbacktrace/internal.h > +++ b/libbacktrace/internal.h > @@ -323,10 +323,22 @@ struct dwarf_sections > > struct dwarf_data; >

Re: [RFC 1/2] libbacktrace: add FDPIC support

2024-06-11 Thread Max Filippov
On Sun, May 26, 2024 at 11:50 PM Max Filippov wrote: > > Instead of a single base address FDPIC ELF files use load map: a > structure with an array of mappings for individual segments. Change > libbacktrace functions and structures to support that. Ping? > libbacktrace/ > > PR libbacktr

[RFC 1/2] libbacktrace: add FDPIC support

2024-05-26 Thread Max Filippov
Instead of a single base address FDPIC ELF files use load map: a structure with an array of mappings for individual segments. Change libbacktrace functions and structures to support that. libbacktrace/ PR libbacktrace/114941 * dwarf.c: Include or if available. (struct d