On Mon, 15 Jul 2024, Ian Lance Taylor wrote:
> Thanks for testing. Committed to mainline with this ChangeLog entry:
>
> * internal.h: If FDPIC, #include <link.h> and/or <sys/link.h>.
> (libbacktrace_using_fdpic): Define.
> (struct libbacktrace_base_address): Define.
> (libbacktrace_add_base): Define.
> (backtrace_dwarf_add): Change base_address to struct
> libbacktrace_base_address.
> * dwarf.c (struct dwarf_data): Change base_address to struct
> libbacktrace_base_address.
I believe this was causing test failures (not bootstrap failures, see
below) on x86_64-unknown-freebsd13.3 (beyond AIX where I just saw David's
report) and it appears to be fixed by your later change.
Thank you!
Gerald
xcoff_32.c: In function "xcoff_add":
xcoff_32.c:1310:40: error: incompatible type for argument 2 of
"backtrace_dwarf_add"
1310 | if (!backtrace_dwarf_add (state, base_address, &dwarf_sections,
| ^~~~~~~~~~~~
| |
| uintptr_t {aka long unsigned int}
In file included from xcoff_32.c:45:
/scratch/tmp/gerald/GCC-HEAD/libbacktrace/internal.h:363:66: note:
expected "struct libbacktrace_base_address" but argument is of type "uintptr_t"
{aka "long unsigned int"}
363 | struct libbacktrace_base_address
base_address,
|
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
gmake[3]: *** [Makefile:1538: xcoff_32.lo] Error 1
xcoff_64.c: In function "xcoff_add":
xcoff_64.c:1310:40: error: incompatible type for argument 2 of
"backtrace_dwarf_add"
1310 | if (!backtrace_dwarf_add (state, base_address, &dwarf_sections,
| ^~~~~~~~~~~~
| |
| uintptr_t {aka long unsigned int}
In file included from xcoff_64.c:45:
/scratch/tmp/gerald/GCC-HEAD/libbacktrace/internal.h:363:66: note:
expected "struct libbacktrace_base_address" but argument is of type "uintptr_t"
{aka "long unsigned int"}
363 | struct libbacktrace_base_address
base_address,
|
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
gmake[3]: *** [Makefile:1538: xcoff_64.lo] Error 1
gmake[2]: *** [Makefile:2516: check-am] Error 2
gmake[1]: *** [Makefile:20931: check-target-libbacktrace] Error 2
