Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-07-22 Thread Ramana Radhakrishnan
On Sat, Jul 12, 2014 at 11:40 PM, Kugan wrote: >> >> - if (!TARGET_VFP) >> -return; >> + if (!TARGET_VFP || TARGET_THUMB1) >> +return default_atomic_assign_expand_fenv (hold, clear, update); >> >> You don't need to call default function here. It is empty, the >> documentation says: >> >>

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-07-12 Thread Kugan
> > - if (!TARGET_VFP) > -return; > + if (!TARGET_VFP || TARGET_THUMB1) > +return default_atomic_assign_expand_fenv (hold, clear, update); > > You don't need to call default function here. It is empty, the > documentation says: > > "The default implementation leaves all three expressio

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-07-12 Thread Uros Bizjak
Hello! > 2014-06-10 Kugan Vivekanandarajah > > * config/arm/arm.c (arm_atomic_assign_expand_fenv): call > default_atomic_assign_expand_fenv for TARGET_THUMB1. > (arm_init_builtins) : Initialize builtins __builtins_arm_set_fpscr and > __builtins_arm_get_fpscr only when !TARGET_THUMB1. > * config

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-06-23 Thread Jay Foad
On 2 May 2014 10:04, Kugan wrote: > Thanks for spotting it. Here is the updated patch that changes it to > ARM_FE_*. > +2014-05-02 Kugan Vivekanandarajah > + > + * config/arm/arm.c (TARGET_ATOMIC_ASSIGN_EXPAND_FENV): New define. > + (arm_builtins) : Add ARM_BUILTIN_GET_FPSCR and AR

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-06-10 Thread Ramana Radhakrishnan
On Tue, Jun 10, 2014 at 12:25 AM, Kugan wrote: > On 30/05/14 18:35, Ramana Radhakrishnan wrote: >>> + if (!TARGET_VFP) >>> +return; >>> + >>> + /* Generate the equivalence of : >> >> s/equivalence/equivalent. >> >> Ok with that change and if no regressions. > > Hi Ramana, > > Sorry, I missed

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-06-09 Thread Kugan
On 30/05/14 18:35, Ramana Radhakrishnan wrote: >> + if (!TARGET_VFP) >> +return; >> + >> + /* Generate the equivalence of : > > s/equivalence/equivalent. > > Ok with that change and if no regressions. Hi Ramana, Sorry, I missed the thumb1 part. There are no mrc/mcr versions of these inst

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-05-30 Thread Ramana Radhakrishnan
>+ if (!TARGET_VFP) >+return; >+ >+ /* Generate the equivalence of : s/equivalence/equivalent. Ok with that change and if no regressions. Ramana On Mon, May 26, 2014 at 9:01 AM, Kugan wrote: > Ping^2 ? > > Thanks, > Kugan > > On 12/05/14 09:47, Kugan wrote: >> Ping ? >> >> Thanks, >> Kug

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-05-26 Thread Kugan
Ping^2 ? Thanks, Kugan On 12/05/14 09:47, Kugan wrote: > Ping ? > > Thanks, > Kugan > > On 02/05/14 19:04, Kugan wrote: >> On 02/05/14 10:15, Joseph S. Myers wrote: >>> It doesn't seem a good idea to me for a host-side GCC file to use the FE_* >>> names for the target's FE_* values; you'd run

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-05-11 Thread Kugan
Ping ? Thanks, Kugan On 02/05/14 19:04, Kugan wrote: > On 02/05/14 10:15, Joseph S. Myers wrote: >> It doesn't seem a good idea to me for a host-side GCC file to use the FE_* >> names for the target's FE_* values; you'd run into problems if that file >> ever ends up including the host's , direc

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-05-02 Thread Kugan
On 02/05/14 10:15, Joseph S. Myers wrote: > It doesn't seem a good idea to me for a host-side GCC file to use the FE_* > names for the target's FE_* values; you'd run into problems if that file > ever ends up including the host's , directly or indirectly, on any > host. The same comment applies

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-05-01 Thread Joseph S. Myers
It doesn't seem a good idea to me for a host-side GCC file to use the FE_* names for the target's FE_* values; you'd run into problems if that file ever ends up including the host's , directly or indirectly, on any host. The same comment applies to the AArch64 patch as well. Instead I suggest

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-04-29 Thread Kugan
On 28/04/14 20:29, Ramana Radhakrishnan wrote: > On 04/26/14 11:26, Kugan wrote: >> Hi, >> >> Attached patch implements TARGET_ATOMIC_ASSIGN_EXPAND_FENV for ARM. With >> this, atomic test-case gcc.dg/atomic/c11-atomic-exec-5.c now PASS. >> >> This implementation is based on SPARC and i386 implemen

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-04-28 Thread Ramana Radhakrishnan
On 04/26/14 11:26, Kugan wrote: Hi, Attached patch implements TARGET_ATOMIC_ASSIGN_EXPAND_FENV for ARM. With this, atomic test-case gcc.dg/atomic/c11-atomic-exec-5.c now PASS. This implementation is based on SPARC and i386 implementations. Regression tested on qemu-arm for arm-none-linux-gnuea

[RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-04-26 Thread Kugan
Hi, Attached patch implements TARGET_ATOMIC_ASSIGN_EXPAND_FENV for ARM. With this, atomic test-case gcc.dg/atomic/c11-atomic-exec-5.c now PASS. This implementation is based on SPARC and i386 implementations. Regression tested on qemu-arm for arm-none-linux-gnueabi with no new regression. Is this