On Sat, Jul 12, 2014 at 11:40 PM, Kugan
<kugan.vivekanandara...@linaro.org> wrote:
>>
>> - if (!TARGET_VFP)
>> - return;
>> + if (!TARGET_VFP || TARGET_THUMB1)
>> + return default_atomic_assign_expand_fenv (hold, clear, update);
>>
>> You don't need to call default function here. It is empty, the
>> documentation says:
>>
>> "The default implementation leaves all three expressions as
>> @code{NULL_TREE}."
>>
>> Also, the function is declared as void, so returning something looks
>> strange to me.
>
> Thanks for the comment. Here is a patch to change this. There was also a
> comment from Jay with respect to a cut and paste error that might
> confuse the readers. I am fixing that as well.
>
> regression tested on qemu for arm-none-linux-gnueabi with no new
> regressions.
>
> Please let me know if this is OK?
Sigh, sorry for missing this earlier. This is OK if no regressions
Ramana
>
> Thanks,
> Kugan
>
> gcc/
> 2014-057-12 Kugan Vivekanandarajah <kug...@linaro.org>
>
> * config/arm/arm.c (bdesc_2arg): Fix typo.
> (arm_atomic_assign_expand_fenv): Remove The default implementation.
