Re: [PATCH v4 3/7] OpenMP: C front-end support for dispatch + adjust_args

2024-10-30 Thread Paul-Antoine Arras
On 30/10/2024 15:08, Tobias Burnus wrote: I still need to look at 4/7 (C++) and 5/7 (tests for C and C++) [either before after you posted the new version]. I sent a revised C++ patch a few moments ago. * * * However, this 3/7 patch LGTM 🙂 One comment: For the < C23 testcase, can you add, e.

Re: [PATCH v4 3/7] OpenMP: C front-end support for dispatch + adjust_args

2024-10-30 Thread Tobias Burnus
Hi, Paul-Antoine Arras wrote: On 24/10/2024 13:42, Tobias Burnus wrote: But there is reason to move them to 5/7: I think we also need a run test for C++ to make sure that it works, i.e. moving them to libgomp.c-c++- common/ makes sense, which in turn requires the 4/7 C++ FE patch. I still n

Re: [PATCH v4 3/7] OpenMP: C front-end support for dispatch + adjust_args

2024-10-30 Thread Paul-Antoine Arras
On 24/10/2024 13:42, Tobias Burnus wrote: Hi, some more comments: Paul-Antoine Arras wrote: Here is an updated patch following these comments. gcc/testsuite/ChangeLog: * gcc.dg/gomp/adjust-args-1.c: New test. * gcc.dg/gomp/dispatch-1.c: New test. The Cha

Re: [PATCH v4 3/7] OpenMP: C front-end support for dispatch + adjust_args

2024-10-24 Thread Tobias Burnus
Hi, some more comments: Paul-Antoine Arras wrote: Here is an updated patch following these comments. gcc/testsuite/ChangeLog: * gcc.dg/gomp/adjust-args-1.c: New test. * gcc.dg/gomp/dispatch-1.c: New test. The ChangeLog misses to include libgomp/testsuite/

Re: [PATCH v4 3/7] OpenMP: C front-end support for dispatch + adjust_args

2024-10-23 Thread Paul-Antoine Arras
Here is an updated patch following these comments. On 09/10/2024 19:15, Tobias Burnus wrote: First comments; I need to have a deeper, but now I need fetch some victuals. Paul-Antoine Arras wrote: This patch adds support to the C front-end to parse the `dispatch` construct and the `adjust_args

Re: [PATCH v4 3/7] OpenMP: C front-end support for dispatch + adjust_args

2024-10-09 Thread Tobias Burnus
First comments; I need to have a deeper, but now I need fetch some victuals. Paul-Antoine Arras wrote: This patch adds support to the C front-end to parse the `dispatch` construct and the `adjust_args` clause. It also includes some common C/C++ bits for pragmas and attributes. Additional common

[PATCH v4 3/7] OpenMP: C front-end support for dispatch + adjust_args

2024-10-02 Thread Paul-Antoine Arras
This patch adds support to the C front-end to parse the `dispatch` construct and the `adjust_args` clause. It also includes some common C/C++ bits for pragmas and attributes. Additional common C/C++ testcases are in a later patch in the series. gcc/c-family/ChangeLog: * c-attribs.cc (c_c