On 30/10/2024 15:08, Tobias Burnus wrote:
I still need to look at 4/7 (C++) and 5/7 (tests for C and C++) [either
before after you posted the new version].
I sent a revised C++ patch a few moments ago.
* * *
However, this 3/7 patch LGTM 🙂
One comment: For the < C23 testcase, can you add, e.g., -std=gnu17 ? The
reason is that Joseph plans to switch to -std=gnu23 by default and
already modified existing testcases, e.g. r15-4391-g9fb5348e302102
"testsuite: Prepare for -std=gnu23 default" – and https://gcc.gnu.org/
pipermail/gcc-patches/2024-October/665612.html
Done.
* * *
In summary, Patches 1 to 3 are now approved 🙂
For 2, I expect a follow that for a known NULL ptr value (0L, nullptr,
(void*)0L, absent argument in Fortran, absent argument in C++ with '=
NULL/nullptr' parameter default), the need_device_ptr conversion will
skip the __builtin_omp_get_mapped_ptr call (at is will just return
NULL); but that can be done later 🙂 [Cf. also my comment to the 4/7
patch.]
I attached an updated ME patch along with the C++ patch.
--
PA
