Hi Tobias,
Thanks for your thorough review.
On 09/10/2024 14:55, Tobias Burnus wrote:
Paul-Antoine Arras wrote:
This patch adds middle-end support for the `dispatch` construct and the
`adjust_args` clause. The heavy lifting is done in
`gimplify_omp_dispatch` and
`gimplify_call_expr` respectiv
Here is the updated patch.
On 23/10/2024 11:41, Tobias Burnus wrote:
* The update to builtins.cc's builtin_fnspec is lacking in the
changelog list.
Added missing items to the ChangeLog.
* And the new testcase, new gcc/testsuite/c-c++-common/gomp/
dispatch-10.c, has to be put into 3/7 or lat
Hi PA,
thanks for the update.
Paul-Antoine Arras wrote:
[…] Please find attached a revised patch.
LGTM, except:
* The update to builtins.cc's builtin_fnspec is lacking in the
changelog list.
* And the new testcase, new
gcc/testsuite/c-c++-common/gomp/dispatch-10.c, has to be put into 3/
Hi Tobias,
Thanks for your thorough review. Please find attached a revised patch.
On 09/10/2024 14:55, Tobias Burnus wrote:
Paul-Antoine Arras wrote:
This patch adds middle-end support for the `dispatch` construct and the
`adjust_args` clause. The heavy lifting is done in
`gimplify_omp_dispat
Minor follow-up comments:
Paul-Antoine Arras wrote:
This patch adds middle-end support for the `dispatch` construct and the
`adjust_args` clause. The heavy lifting is done in `gimplify_omp_dispatch` and
`gimplify_call_expr` respectively. For `adjust_args`, this mostly consists in
emitting a call
Hi PA,
sorry for the slow review. Looks mostly fine, but I stumbled over a few
minor points. Some are only RFC items (some of the 'I wonder …').
Paul-Antoine Arras wrote:
This patch adds middle-end support for the `dispatch` construct and the
`adjust_args` clause. The heavy lifting is done i
This patch adds middle-end support for the `dispatch` construct and the
`adjust_args` clause. The heavy lifting is done in `gimplify_omp_dispatch` and
`gimplify_call_expr` respectively. For `adjust_args`, this mostly consists in
emitting a call to `gomp_get_mapped_ptr` for the adequate device.
For
