Hi PA,
thanks for the update.
Paul-Antoine Arras wrote:
[…] Please find attached a revised patch.
LGTM, except:
* The update to builtins.cc's builtin_fnspec is lacking in the
changelog list.
* And the new testcase, new
gcc/testsuite/c-c++-common/gomp/dispatch-10.c, has to be put into 3/7 or
later of the series as it requires a parser and, as written/file
location, requires both C and C++, unless a skip for C is added. I
wonder whether a scan tree-dump check should be added as well.
Next comes the C parser …
* On your side: There is one ICE (testcase in last patch review for 2/7)
when the variant function has not been declared but used in 'declare
variant' + adjust_args, which needs to be fixed. As has the [3] vs [6]
array size issue, I mentioned in my 3/7 review. And probably more …
* And on my side: Still have to finish reviewing that patch.
Tobias
