Re: [PATCH v3 1/2] aarch64: Use standard names for saturating arithmetic

2025-01-17 Thread Kyrylo Tkachov
gcc-patches@gcc.gnu.org >>> Subject: Re: [PATCH v3 1/2] aarch64: Use standard names for saturating >>> arithmetic >>> >>> Akram Ahmad writes: >>>> Ah whoops- I didn't see this before sending off V4 just now, my apologies. >>>> I'

Re: [PATCH v3 1/2] aarch64: Use standard names for saturating arithmetic

2025-01-17 Thread Richard Sandiford
Tamar Christina writes: >> -Original Message- >> From: Richard Sandiford >> Sent: Friday, January 10, 2025 4:50 PM >> To: Akram Ahmad >> Cc: ktkac...@nvidia.com; gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH v3 1/2] aarch64: Use standard names for sa

RE: [PATCH v3 1/2] aarch64: Use standard names for saturating arithmetic

2025-01-17 Thread Tamar Christina
> -Original Message- > From: Richard Sandiford > Sent: Friday, January 10, 2025 4:50 PM > To: Akram Ahmad > Cc: ktkac...@nvidia.com; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH v3 1/2] aarch64: Use standard names for saturating > arithmetic > > Akram Ahma

Re: [PATCH v3 1/2] aarch64: Use standard names for saturating arithmetic

2025-01-10 Thread Richard Sandiford
Akram Ahmad writes: > Ah whoops- I didn't see this before sending off V4 just now, my apologies. > I'll try my best to get this implemented before the end of the day so that > it doesn't miss the deadline. No rush! The delay here is entirely my fault, so no problem if the patch lands early stage

Re: [PATCH v3 1/2] aarch64: Use standard names for saturating arithmetic

2025-01-10 Thread Akram Ahmad
On 09/01/2025 23:04, Richard Sandiford wrote: + gcc_assert (imm != 0); The constraints do allow 0, so I'm not sure this assert is safe. Certainly we shouldn't usually get unfolded instructions, but strange things can happen with fuzzed options. Does the code mishandle that case? It looke

Re: [PATCH v3 1/2] aarch64: Use standard names for saturating arithmetic

2025-01-10 Thread Akram Ahmad
Ah whoops- I didn't see this before sending off V4 just now, my apologies. I'll try my best to get this implemented before the end of the day so that it doesn't miss the deadline. On 09/01/2025 23:04, Richard Sandiford wrote: Akram Ahmad writes: In the above example, subtraction replaces the a

Re: [PATCH v3 1/2] aarch64: Use standard names for saturating arithmetic

2025-01-09 Thread Richard Sandiford
Akram Ahmad writes: > Hi Kyrill, > > Thanks for the feedback on V2. I found a pattern which works for > the open-coded signed arithmetic, and I've implemented the other > feedback you provided as well. > > I've send the modified patch in this thread as the SVE patch [2/2] > hasn't been changed, bu

Re: [PATCH v3 1/2] aarch64: Use standard names for saturating arithmetic

2025-01-09 Thread Kyrylo Tkachov
Hi Akram > On 8 Jan 2025, at 16:23, Akram Ahmad wrote: > > Hi Kyrill, > > Thanks for the feedback on V2. I found a pattern which works for > the open-coded signed arithmetic, and I've implemented the other > feedback you provided as well. > > I've send the modified patch in this thread as the

[PATCH v3 1/2] aarch64: Use standard names for saturating arithmetic

2025-01-08 Thread Akram Ahmad
Hi Kyrill, Thanks for the feedback on V2. I found a pattern which works for the open-coded signed arithmetic, and I've implemented the other feedback you provided as well. I've send the modified patch in this thread as the SVE patch [2/2] hasn't been changed, but I'm happy to send the entire V3 p