On 09/01/2025 23:04, Richard Sandiford wrote:
+ gcc_assert (imm != 0);
The constraints do allow 0, so I'm not sure this assert is safe.
Certainly we shouldn't usually get unfolded instructions, but strange
things can happen with fuzzed options.
Does the code mishandle that case? It looked like it should be ok.
I accidentally deleted my response when trimming down the quote text- I
haven't tested this, but it came about from an offline discussion about
the patch with a teammate. It should be fine without the assert, but
I'll test it to make sure.
