Re: [PATCH v2] c-family: Add __builtin_assoc_barrier

2021-09-08 Thread Matthias Kretz
On Wednesday, 8 September 2021 15:44:28 CEST Jason Merrill wrote: > On 9/8/21 5:37 AM, Matthias Kretz wrote: > > On Tuesday, 7 September 2021 19:36:22 CEST Jason Merrill wrote: > >>> case PAREN_EXPR: > >>> - RETURN (finish_parenthesized_expr (RECUR (TREE_OPERAND (t, 0; > >>> + if (REF

Re: [PATCH v2] c-family: Add __builtin_assoc_barrier

2021-09-08 Thread Jason Merrill via Gcc-patches
On 9/8/21 5:37 AM, Matthias Kretz wrote: On Tuesday, 7 September 2021 19:36:22 CEST Jason Merrill wrote: case PAREN_EXPR: - RETURN (finish_parenthesized_expr (RECUR (TREE_OPERAND (t, 0; + if (REF_PARENTHESIZED_P (t)) + RETURN (finish_parenthesized_expr (RECUR (TREE_OPERAND (t

Re: [PATCH v2] c-family: Add __builtin_assoc_barrier

2021-09-08 Thread Matthias Kretz
On Tuesday, 7 September 2021 19:36:22 CEST Jason Merrill wrote: > > case PAREN_EXPR: > > - RETURN (finish_parenthesized_expr (RECUR (TREE_OPERAND (t, 0; > > + if (REF_PARENTHESIZED_P (t)) > > + RETURN (finish_parenthesized_expr (RECUR (TREE_OPERAND (t, 0; > > + else > >

Re: [PATCH v2] c-family: Add __builtin_assoc_barrier

2021-09-07 Thread Jason Merrill via Gcc-patches
On 9/6/21 8:21 AM, Matthias Kretz wrote: Hi, On Tuesday, 20 July 2021 22:22:02 CEST Jason Merrill wrote: The C++ front end already uses PAREN_EXPR in templates to indicate parenthesized initializers in cases where that matters for decltype(auto). It should be fine to use it for both that and _

Re: [PATCH v2] c-family: Add __builtin_assoc_barrier

2021-09-06 Thread Matthias Kretz
On Monday, 6 September 2021 14:59:27 CEST Richard Biener wrote: > On Mon, 6 Sep 2021, Matthias Kretz wrote: > > On Monday, 6 September 2021 14:40:31 CEST Richard Biener wrote: > > > I'll note that currently a + PAREN_EXPR (b * c) is for example > > > also not contracted to PAREN_EXPR (FMA (PAREN_EX

Re: [PATCH v2] c-family: Add __builtin_assoc_barrier

2021-09-06 Thread Richard Biener via Gcc-patches
On Mon, 6 Sep 2021, Matthias Kretz wrote: > On Monday, 6 September 2021 14:40:31 CEST Richard Biener wrote: > > I'll note that currently a + PAREN_EXPR (b * c) is for example > > also not contracted to PAREN_EXPR (FMA (PAREN_EXPR (a), b, c)) > > even though technically FP contraction is not associ

Re: [PATCH v2] c-family: Add __builtin_assoc_barrier

2021-09-06 Thread Matthias Kretz
On Monday, 6 September 2021 14:40:31 CEST Richard Biener wrote: > I'll note that currently a + PAREN_EXPR (b * c) is for example > also not contracted to PAREN_EXPR (FMA (PAREN_EXPR (a), b, c)) > even though technically FP contraction is not association. But > that's an implementation detail that

Re: [PATCH v2] c-family: Add __builtin_assoc_barrier

2021-09-06 Thread Richard Biener via Gcc-patches
On Mon, 6 Sep 2021, Matthias Kretz wrote: > Hi, > > On Tuesday, 20 July 2021 22:22:02 CEST Jason Merrill wrote: > > The C++ front end already uses PAREN_EXPR in templates to indicate > > parenthesized initializers in cases where that matters for > > decltype(auto). It should be fine to use it fo

[PATCH v2] c-family: Add __builtin_assoc_barrier

2021-09-06 Thread Matthias Kretz
Hi, On Tuesday, 20 July 2021 22:22:02 CEST Jason Merrill wrote: > The C++ front end already uses PAREN_EXPR in templates to indicate > parenthesized initializers in cases where that matters for > decltype(auto). It should be fine to use it for both that and > __builtin_assoc_barrier, but you prob