Re: [PATCH 8/8] Add a common .md file and define standard constraints there

2014-06-16 Thread Steve Ellcey
On Sat, 2014-06-14 at 08:49 +0100, Richard Sandiford wrote: > The patch below fixes the testcase. Please could you give it a spin > and see whether there's any other fallout? I assume this would have > shown up in a testsuite run if you'd been able to get that far. > > Thanks, > Richard The pa

Re: [PATCH 8/8] Add a common .md file and define standard constraints there

2014-06-14 Thread Richard Sandiford
Segher Boessenkool writes: >> > * cris, m68k, pdp11, and vax actually use "g". >> > >> > So it won't be all that much work to completely get rid of "g". >> > Do we want that? >> >> Is it simply a matter of replacing “g” by “mri”? That’s what the doc >> suggests. Or is there more to the story t

Re: [PATCH 8/8] Add a common .md file and define standard constraints there

2014-06-14 Thread Richard Sandiford
Steve Ellcey writes: > Richard, > > Something in these constraint patches broke my mips16 build (I cannot > build glibc in mips16 mode). I have cut down a test case and verified > that the problem started with this checkin: > > 2014-06-11 Richard Sandiford > > * common.md: New file. >

Re: [PATCH 8/8] Add a common .md file and define standard constraints there

2014-06-13 Thread Steve Ellcey
Richard, Something in these constraint patches broke my mips16 build (I cannot build glibc in mips16 mode). I have cut down a test case and verified that the problem started with this checkin: 2014-06-11 Richard Sandiford * common.md: New file. * doc/md.texi: Update descripti

Re: [PATCH 8/8] Add a common .md file and define standard constraints there

2014-06-12 Thread Segher Boessenkool
> > * cris, m68k, pdp11, and vax actually use "g". > > > > So it won't be all that much work to completely get rid of "g". > > Do we want that? > > Is it simply a matter of replacing “g” by “mri”? That’s what the doc > suggests. Or is there more to the story than that? As far as I know "g" an

Re: [PATCH 8/8] Add a common .md file and define standard constraints there

2014-06-12 Thread Paul_Koning
On Jun 12, 2014, at 3:24 PM, Segher Boessenkool wrote: > On Thu, Jun 05, 2014 at 10:43:25PM +0100, Richard Sandiford wrote: >> This final patch uses a common .md file to define all standard >> constraints except 'g'. > > I had a look at what targets still use "g". Note: there can be > errors

Re: [PATCH 8/8] Add a common .md file and define standard constraints there

2014-06-12 Thread Segher Boessenkool
On Thu, Jun 05, 2014 at 10:43:25PM +0100, Richard Sandiford wrote: > This final patch uses a common .md file to define all standard > constraints except 'g'. I had a look at what targets still use "g". Note: there can be errors in this, it's all based on \

Re: [PATCH 8/8] Add a common .md file and define standard constraints there

2014-06-11 Thread Richard Sandiford
Thanks for the reviews. Jeff Law writes: > Does the comment before indep_constraints in genoutput need updating? > The constraints in common.md are machine independent, but aren't listed > in indep_constraints in genoutput.c Yeah, good catch. I changed it to: /* All machine-independent const

Re: [PATCH 8/8] Add a common .md file and define standard constraints there

2014-06-10 Thread Jeff Law
On 06/05/14 15:43, Richard Sandiford wrote: This final patch uses a common .md file to define all standard constraints except 'g'. It then gets rid of explicit case statements for the standard constraints, except in two cases: (1) recog.c:asm_operand_ok still needs to handle 'o' specially for

[PATCH 8/8] Add a common .md file and define standard constraints there

2014-06-05 Thread Richard Sandiford
This final patch uses a common .md file to define all standard constraints except 'g'. It then gets rid of explicit case statements for the standard constraints, except in two cases: (1) recog.c:asm_operand_ok still needs to handle 'o' specially for targets like ia64 that don't have offsettab