Re: [PATCH 5/7 libgomp,amdgcn] Optimize GCN OpenMP malloc performance

2019-11-12 Thread Jakub Jelinek
On Tue, Nov 12, 2019 at 05:47:11PM +, Andrew Stubbs wrote: > > Not really sure if it is a good idea to print anything, at least not when > > in some debugging mode. I mean, it is fairly easy to write code that will > > trigger this. And, what is the reason why you can't free the > > gomp_mall

Re: [PATCH 5/7 libgomp,amdgcn] Optimize GCN OpenMP malloc performance

2019-11-12 Thread Andrew Stubbs
On 12/11/2019 13:56, Jakub Jelinek wrote: s/reeduced/reduced/ Done. Not really sure if it is a good idea to print anything, at least not when in some debugging mode. I mean, it is fairly easy to write code that will trigger this. And, what is the reason why you can't free the gomp_malloced

Re: [PATCH 5/7 libgomp,amdgcn] Optimize GCN OpenMP malloc performance

2019-11-12 Thread Jakub Jelinek
On Tue, Nov 12, 2019 at 01:29:14PM +, Andrew Stubbs wrote: > 2019-11-12 Andrew Stubbs > > libgomp/ > * config/gcn/team.c (gomp_gcn_enter_kernel): Set up the team arena > and use team_malloc variants. > (gomp_gcn_exit_kernel): Use team_free. > * libgomp.h (TEAM_

[PATCH 5/7 libgomp,amdgcn] Optimize GCN OpenMP malloc performance

2019-11-12 Thread Andrew Stubbs
This patch implements a malloc optimization to improve the startup and shutdown overhead for each OpenMP team. New malloc functions are created, "team_malloc" and "team_free", that take memory from a per-team memory arena provided by the plugin, rather than the shared heap space, which is slow, an