On Tue, Nov 12, 2019 at 05:47:11PM +0000, Andrew Stubbs wrote:
> > Not really sure if it is a good idea to print anything, at least not when
> > in some debugging mode. I mean, it is fairly easy to write code that will
> > trigger this. And, what is the reason why you can't free the
> > gomp_malloced memory, like comparing if the team_freed pointer is in between
> > TEAM_ARENA_START and TEAM_ARENA_END or similar, don't do anything in that
> > case, otherwise use free?
>
> Falling back to malloc is a big performance hit. There's a global lock
> affecting all teams in all running kernels. If we're running into this then
> a) I want to know about it so I can tune the arena size, and b) I want the
> user to know why performance is suddenly worse.
>
> At least for now, I want to keep the message. I've updated the comment
> though.
At some point we'll need to pass some data from the host to offloading
target, including ICVs etc. (at least for OpenMP 5.1) and at that point we
can pass also the GOMP_DEBUG state.
> I wanted to ensure that the loop would vectorize inline, but I don't think
> it was doing so anyway. I need to look at that, but how is this, for now?
Ok.
Jakub
