Re: [PATCH 225/236] Work towards NEXT_INSN/PREV_INSN requiring insns as their params

2014-08-28 Thread Richard Henderson
On 08/28/2014 05:47 PM, David Malcolm wrote: > - insn = as_a ( > -gen_extend_insn (op0, t, promoted_nominal_mode, > - data->passed_mode, unsignedp)); > - emit_insn (insn); > + rtx pat = gen_extend_insn (op0, t, promoted_nominal_mode

Re: [PATCH 225/236] Work towards NEXT_INSN/PREV_INSN requiring insns as their params

2014-08-28 Thread David Malcolm
On Thu, 2014-08-28 at 17:08 -0700, H.J. Lu wrote: > On Tue, Aug 26, 2014 at 10:15 AM, David Malcolm wrote: > > On Mon, 2014-08-25 at 08:25 -0600, Jeff Law wrote: > >> On 08/19/14 15:35, David Malcolm wrote: > >> > On Tue, 2014-08-19 at 13:57 -0700, Richard Henderson wrote: > >> >> On 08/06/2014 10

Re: [PATCH 225/236] Work towards NEXT_INSN/PREV_INSN requiring insns as their params

2014-08-28 Thread H.J. Lu
On Tue, Aug 26, 2014 at 10:15 AM, David Malcolm wrote: > On Mon, 2014-08-25 at 08:25 -0600, Jeff Law wrote: >> On 08/19/14 15:35, David Malcolm wrote: >> > On Tue, 2014-08-19 at 13:57 -0700, Richard Henderson wrote: >> >> On 08/06/2014 10:23 AM, David Malcolm wrote: >> >>> diff --git a/gcc/cfgrtl.

Re: [PATCH 225/236] Work towards NEXT_INSN/PREV_INSN requiring insns as their params

2014-08-28 Thread Richard Henderson
On 08/26/2014 10:15 AM, David Malcolm wrote: > Attached is a revised version of #225, with the following changes: > > * fix for the above: avoid introducing a new shadow name "note" within > force_nonfallthru_and_redirect by introducing a new local rtx_insn * > "new_head" and renaming "note" to it

Re: [PATCH 225/236] Work towards NEXT_INSN/PREV_INSN requiring insns as their params

2014-08-26 Thread David Malcolm
On Mon, 2014-08-25 at 08:25 -0600, Jeff Law wrote: > On 08/19/14 15:35, David Malcolm wrote: > > On Tue, 2014-08-19 at 13:57 -0700, Richard Henderson wrote: > >> On 08/06/2014 10:23 AM, David Malcolm wrote: > >>> diff --git a/gcc/cfgrtl.c b/gcc/cfgrtl.c > >>> index 59d633d..5e42a97 100644 > >>> ---

Re: [PATCH 225/236] Work towards NEXT_INSN/PREV_INSN requiring insns as their params

2014-08-25 Thread Jeff Law
On 08/19/14 15:35, David Malcolm wrote: On Tue, 2014-08-19 at 13:57 -0700, Richard Henderson wrote: On 08/06/2014 10:23 AM, David Malcolm wrote: diff --git a/gcc/cfgrtl.c b/gcc/cfgrtl.c index 59d633d..5e42a97 100644 --- a/gcc/cfgrtl.c +++ b/gcc/cfgrtl.c @@ -1604,6 +1604,7 @@ force_nonfallthru_a

Re: [PATCH 225/236] Work towards NEXT_INSN/PREV_INSN requiring insns as their params

2014-08-19 Thread Richard Henderson
On 08/19/2014 02:35 PM, David Malcolm wrote: > This one is quite ugly: the pre-existing code has two locals named > "note", both of type rtx, with one shadowing the other. This patch > introduces a third, within the scope where the name "note" is used for > insns. In the other scopes the two othe

Re: [PATCH 225/236] Work towards NEXT_INSN/PREV_INSN requiring insns as their params

2014-08-19 Thread David Malcolm
On Tue, 2014-08-19 at 13:57 -0700, Richard Henderson wrote: > On 08/06/2014 10:23 AM, David Malcolm wrote: > > diff --git a/gcc/cfgrtl.c b/gcc/cfgrtl.c > > index 59d633d..5e42a97 100644 > > --- a/gcc/cfgrtl.c > > +++ b/gcc/cfgrtl.c > > @@ -1604,6 +1604,7 @@ force_nonfallthru_and_redirect (edge e, b

Re: [PATCH 225/236] Work towards NEXT_INSN/PREV_INSN requiring insns as their params

2014-08-19 Thread Richard Henderson
On 08/06/2014 10:23 AM, David Malcolm wrote: > diff --git a/gcc/cfgrtl.c b/gcc/cfgrtl.c > index 59d633d..5e42a97 100644 > --- a/gcc/cfgrtl.c > +++ b/gcc/cfgrtl.c > @@ -1604,6 +1604,7 @@ force_nonfallthru_and_redirect (edge e, basic_block > target, rtx jump_label) > >if (EDGE_COUNT (e->src->s

[PATCH 225/236] Work towards NEXT_INSN/PREV_INSN requiring insns as their params

2014-08-06 Thread David Malcolm
gcc/ * cfgexpand.c (pass_expand::execute): Strengthen local "after" from rtx to rtx_insn *. * cfgrtl.c (force_nonfallthru_and_redirect): Add local "note" of type rtx_insn * in scope where it's needed. * combine.c (combine_split_insns): Strengthen return type