On 08/19/2014 02:35 PM, David Malcolm wrote: > This one is quite ugly: the pre-existing code has two locals named > "note", both of type rtx, with one shadowing the other. This patch > introduces a third, within the scope where the name "note" is used for > insns. In the other scopes the two other "note" variables are used for > find_reg_note. In each case, the name "note" is written to before use. > > So in my defense, the existing code already had shadowing of locals... > but I guess that's not much of a defense, and it would be better to > introduce a different name, and rename the uses in the appropriate > scope.
Or, if possible, narrow the scope of the other names such that there is no shadowing. r~
