Re: [PATCH 2/2] Documentation hyperlinks for [-Wname-of-option] (PR 87488)

2019-10-14 Thread Michael Matz
Hi, On Thu, 10 Oct 2019, David Malcolm wrote: > This patch uses the support for pretty-printing escaped URLs added in > the previous patch (PR 87488) so that in a sufficiently capable terminal > the [-Wname-of-option] emitted at the end of each diagnostic becomes a > hyperlink to the documenta

Re: [PATCH 2/2] Documentation hyperlinks for [-Wname-of-option] (PR 87488)

2019-10-12 Thread Segher Boessenkool
On Sat, Oct 12, 2019 at 10:21:56AM -0400, David Malcolm wrote: > It seems like instead it's displaying this: > > https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wshadow=local-Wshadow=local%1B]8 That's what it does for me (well, with weird escapes at both ends). And if run inside a

Re: [PATCH 2/2] Documentation hyperlinks for [-Wname-of-option] (PR 87488)

2019-10-12 Thread Bernd Edlinger
On 10/12/19 4:21 PM, David Malcolm wrote: > On Sat, 2019-10-12 at 07:00 +, Bernd Edlinger wrote: >> Hi David, >> >> I just wanted to say that this does not work right on ubuntu 14.04 at >> least: >> >> g++ -Wshadow=local -Wno-shadow=compatible-local -S Wshadow-1.c >> Wshadow-1.c: In function

Re: [PATCH 2/2] Documentation hyperlinks for [-Wname-of-option] (PR 87488)

2019-10-12 Thread David Malcolm
On Sat, 2019-10-12 at 07:00 +, Bernd Edlinger wrote: > Hi David, > > I just wanted to say that this does not work right on ubuntu 14.04 at > least: > > g++ -Wshadow=local -Wno-shadow=compatible-local -S Wshadow-1.c > Wshadow-1.c: In function 'void foo(int*, int*)': > Wshadow-1.c:8:9: warning

Re: [PATCH 2/2] Documentation hyperlinks for [-Wname-of-option] (PR 87488)

2019-10-12 Thread Bernd Edlinger
Hi David, I just wanted to say that this does not work right on ubuntu 14.04 at least: g++ -Wshadow=local -Wno-shadow=compatible-local -S Wshadow-1.c Wshadow-1.c: In function 'void foo(int*, int*)': Wshadow-1.c:8:9: warning: declaration of 'int d' shadows a parameter []8;;https://gcc.gnu.org/o

Re: [PATCH 2/2] Documentation hyperlinks for [-Wname-of-option] (PR 87488)

2019-10-10 Thread Eric Gallager
On 10/10/19, Manuel López-Ibáñez wrote: > Hi David, > > While I agree that this is quite cool to have, the following: > >> +/* DOCUMENTATION_ROOT_URL should be supplied via -D by the Makefile >> + (see --with-documentation-root-url). >> + >> + Expect an anchor of the form "index-Wf

Re: [PATCH 2/2] Documentation hyperlinks for [-Wname-of-option] (PR 87488)

2019-10-10 Thread Manuel López-Ibáñez
Hi David, While I agree that this is quite cool to have, the following: +/* DOCUMENTATION_ROOT_URL should be supplied via -D by the Makefile + (see --with-documentation-root-url). + + Expect an anchor of the form "index-Wfoo" e.g. + , and thus an id within + the URL

[PATCH 2/2] Documentation hyperlinks for [-Wname-of-option] (PR 87488)

2019-10-10 Thread David Malcolm
This patch uses the support for pretty-printing escaped URLs added in the previous patch (PR 87488) so that in a sufficiently capable terminal the [-Wname-of-option] emitted at the end of each diagnostic becomes a hyperlink to the documentation for that option on the GCC website. I've tested it wi