Re: [PATCH 1/3] libstdc++: Add time_get::get support.

2014-12-22 Thread Dominique Dhumieres
> I think I've fixed them now though, and am committing the attached > patch to trunk. This commit (or a friend of it) breaks bootstrap on darwin duplicate symbol std::__cxx11::time_get > >::do_get(std::istreambuf_iterator >, std::istreambuf_iterator >, std::ios_base&, std::_Ios_Iostate&, tm*, c

Re: [PATCH 1/3] libstdc++: Add time_get::get support.

2014-12-22 Thread Jonathan Wakely
On 15/04/14 23:19 +0200, Rüdiger Sonderfeld wrote: + TESTHEAD("check broken format"); + iss.str("2014-04-14 01:09:35"); + format = "%"; + ret = tget.get(istreambuf_iterator(iss), end, iss, err, &time, + format.data(), format.data()+format.size()); + VERIFY(err == ios_base::fa

Re: [PATCH 1/3] libstdc++: Add time_get::get support.

2014-12-20 Thread Jonathan Wakely
On 20/12/14 13:07 +, Jonathan Wakely wrote: On 15/04/14 23:19 +0200, Rüdiger Sonderfeld wrote: This patch adds support for std::time_get::get and std::time_get::do_get [locale.time.get]. Currently do_get is not virtual because this caused segfault errors for me. Hi Rüdiger, I'm trying to

Re: [PATCH 1/3] libstdc++: Add time_get::get support.

2014-12-20 Thread Jonathan Wakely
On 15/04/14 23:19 +0200, Rüdiger Sonderfeld wrote: This patch adds support for std::time_get::get and std::time_get::do_get [locale.time.get]. Currently do_get is not virtual because this caused segfault errors for me. Hi Rüdiger, I'm trying to apply this patch and the tests don't work. There

Re: [PATCH 1/3] libstdc++: Add time_get::get support.

2014-04-16 Thread Jonathan Wakely
On 16/04/14 13:19 +0200, Rüdiger Sonderfeld wrote: On Tuesday 15 April 2014 23:36:51 Paolo Carlini wrote: Those should be isolated and a compiler bug report opened including a minimized reproducer. I'm not sure if this is a compiler bug or simply due to the fact that I didn't add the virtual f

Re: [PATCH 1/3] libstdc++: Add time_get::get support.

2014-04-16 Thread Rüdiger Sonderfeld
On Tuesday 15 April 2014 23:36:51 Paolo Carlini wrote: > Those should be isolated and a compiler bug report opened including a > minimized reproducer. I'm not sure if this is a compiler bug or simply due to the fact that I didn't add the virtual function to the ABI linker script. > Anyway, the r

Libstdc++ ABI transition (was: Re: [PATCH 1/3] libstdc++: Add time_get::get support.)

2014-04-16 Thread Jonathan Wakely
On 16 April 2014 06:58, Marc Glisse wrote: > On Tue, 15 Apr 2014, Paolo Carlini wrote: > >> Anyway, the real issue is indeed that implementing those bits requires a >> new virtual function, and that would break the ABI. > > > What is the status of the ABI half-break plan (abi_tag and such), necessa

Re: [PATCH 1/3] libstdc++: Add time_get::get support.

2014-04-15 Thread Marc Glisse
On Tue, 15 Apr 2014, Paolo Carlini wrote: Anyway, the real issue is indeed that implementing those bits requires a new virtual function, and that would break the ABI. What is the status of the ABI half-break plan (abi_tag and such), necessary to get the remaining pieces of C++11? -- Marc Gl

Re: [PATCH 1/3] libstdc++: Add time_get::get support.

2014-04-15 Thread Paolo Carlini
Hi, On 04/15/2014 11:19 PM, Rüdiger Sonderfeld wrote: This patch adds support for std::time_get::get and std::time_get::do_get [locale.time.get]. Currently do_get is not virtual because this caused segfault errors for me. Those should be isolated and a compiler bug report opened including a mi

[PATCH 1/3] libstdc++: Add time_get::get support.

2014-04-15 Thread Rüdiger Sonderfeld
This patch adds support for std::time_get::get and std::time_get::do_get [locale.time.get]. Currently do_get is not virtual because this caused segfault errors for me. * libstdc++-v3/include/bits/locale_facets_nonio.h (time_get::get): (time_get::do_get): New method (C++11). * libstdc++-v3/incl