Re: [PATCH 1/2] analyzer: detect and analyze calls via function pointer (GSoC)

2021-08-18 Thread David Malcolm via Gcc-patches
On Wed, 2021-08-18 at 12:19 -0400, David Malcolm wrote: > On Tue, 2021-08-17 at 20:40 +0530, Ankur Saini wrote: > > Here is the final patch after fixing all the nits mentioned. > > > > Successfully bootstrapped and completed regress tests on x86_64- > > linux- > > gnu. > > Great, thanks! > > A

Re: [PATCH 1/2] analyzer: detect and analyze calls via function pointer (GSoC)

2021-08-18 Thread David Malcolm via Gcc-patches
On Tue, 2021-08-17 at 20:40 +0530, Ankur Saini wrote: > Here is the final patch after fixing all the nits mentioned. > > Successfully bootstrapped and completed regress tests on x86_64-linux- > gnu. Great, thanks! A very minor nit re ChangeLog entries: when referencing a PR in a patch, typicall

Re: [PATCH 1/2] analyzer: detect and analyze calls via function pointer (GSoC)

2021-08-17 Thread Ankur Saini via Gcc-patches
Here is the final patch after fixing all the nits mentioned. Successfully bootstrapped and completed regress tests on x86_64-linux-gnu. - - - vfunc.patch Description: Binary data Thanks - Ankur

Re: [PATCH 1/2] analyzer: detect and analyze calls via function pointer (GSoC)

2021-08-16 Thread David Malcolm via Gcc-patches
On Mon, 2021-08-16 at 22:27 +0530, Ankur Saini wrote: > > Thanks for the review > > > On 16-Aug-2021, at 4:48 AM, David Malcolm > > wrote: > > > > Thanks, this is looking promising.  Has this been rebased recently > > (e.g. since I merged > >  https://gcc.gnu.org/pipermail/gcc-patches/2021-Augu

Re: [PATCH 1/2] analyzer: detect and analyze calls via function pointer (GSoC)

2021-08-16 Thread Ankur Saini via Gcc-patches
Thanks for the review > On 16-Aug-2021, at 4:48 AM, David Malcolm wrote: > > Thanks, this is looking promising. Has this been rebased recently > (e.g. since I merged > https://gcc.gnu.org/pipermail/gcc-patches/2021-August/576737.html ) Yes, The branch is totally up to date with master at the

Re: [PATCH 1/2] analyzer: detect and analyze calls via function pointer (GSoC)

2021-08-15 Thread David Malcolm via Gcc-patches
On Sun, 2021-08-15 at 20:28 +0530, Ankur Saini wrote: > The patch extends the analyser’s functionality to understand and > analyze indirect calls (calls via a function pointer or calls to > virtual functions ) > > On successful merging, the patch should also fix the following bugs :- > > 1. htt

[PATCH 1/2] analyzer: detect and analyze calls via function pointer (GSoC)

2021-08-15 Thread Ankur Saini via Gcc-patches
The patch extends the analyser’s functionality to understand and analyze indirect calls (calls via a function pointer or calls to virtual functions ) On successful merging, the patch should also fix the following bugs :- 1. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100546 2. https://gcc.gnu