On Tue, 2021-08-17 at 20:40 +0530, Ankur Saini wrote:
> Here is the final patch after fixing all the nits mentioned.
>
> Successfully bootstrapped and completed regress tests on x86_64-linux-
> gnu.
Great, thanks!
A very minor nit re ChangeLog entries: when referencing a PR in a
patch, typically *each* ChangeLog fragment should reference the patch,
not just one. So e.g. in....
gcc/analyzer/ChangeLog:
PR analyzer/100546
* analysis-plan.cc (analysis_plan::use_summary_p): Don't use call
summaries if there is no callgraph edge
[...snip...]
gcc/testsuite/ChangeLog:
* gcc.dg/analyzer/function-ptr-4.c: New test.
* gcc.dg/analyzer/pr100546.c: New test.
...the "gcc/testsuite/ChangeLog:" should also have a reference to "PR
analyzer/100546".
Please go ahead and push these to trunk/master.
Dave
