Re: [PATCH ] PR 844422 Fix FCTID, FCTIW with -mcpu=power7

2018-03-20 Thread Peter Bergner
On 3/16/18 5:51 PM, Segher Boessenkool wrote: > But fctiw is an ISA 1.xx instruction already (and fctid is as well, > but explicitly undefined for 32-bit implementations until some 2.xx, > I forgot which, 2.02 I think?) > > Requiring power8 for it is weird and surprising. power8-vector doubly so.

Re: [PATCH ] PR 844422 Fix FCTID, FCTIW with -mcpu=power7

2018-03-19 Thread Segher Boessenkool
On Mon, Mar 19, 2018 at 08:19:18AM -0500, Bill Schmidt wrote: > > Requiring power8 for it is weird and surprising. power8-vector doubly so. > > > > It does not seem to be a good idea to only enable the builtin for cases > > where the current implementation is not broken. > > > > (The issue is th

Re: [PATCH ] PR 844422 Fix FCTID, FCTIW with -mcpu=power7

2018-03-19 Thread Bill Schmidt
> On Mar 19, 2018, at 8:19 AM, Bill Schmidt wrote: > > On Mar 16, 2018, at 5:51 PM, Segher Boessenkool > wrote: >> >> Hi Carl, >> >> On Wed, Mar 14, 2018 at 08:27:08AM -0700, Carl Love wrote: >>> The following patch fixes an ICE when compiling the test case >>> >>> gcc -mcpu=power7 builtin-

Re: [PATCH ] PR 844422 Fix FCTID, FCTIW with -mcpu=power7

2018-03-19 Thread Bill Schmidt
On Mar 16, 2018, at 5:51 PM, Segher Boessenkool wrote: > > Hi Carl, > > On Wed, Mar 14, 2018 at 08:27:08AM -0700, Carl Love wrote: >> The following patch fixes an ICE when compiling the test case >> >> gcc -mcpu=power7 builtin-fctid-fctiw-runnable.c >> >> The GCC compiler now gives a message

Re: [PATCH ] PR 844422 Fix FCTID, FCTIW with -mcpu=power7

2018-03-16 Thread Segher Boessenkool
Hi Carl, On Wed, Mar 14, 2018 at 08:27:08AM -0700, Carl Love wrote: > The following patch fixes an ICE when compiling the test case > > gcc -mcpu=power7 builtin-fctid-fctiw-runnable.c > > The GCC compiler now gives a message  > > "error: builtin function ‘__builtin_fctiw’ requires the ‘-m

[PATCH ] PR 844422 Fix FCTID, FCTIW with -mcpu=power7

2018-03-14 Thread Carl Love
GCC Maintainers: The following patch fixes an ICE when compiling the test case gcc -mcpu=power7 builtin-fctid-fctiw-runnable.c The GCC compiler now gives a message  "error: builtin function ‘__builtin_fctiw’ requires the ‘-mpower8-vector’ option"  and exits without generating an interna