On Oct 18, 2013, at 6:36 AM, David Malcolm wrote:
> Thanks everyone; I'm finding this very helpful.
Thanks for the feedback and making enough noise such that we fixed the problem.
:-)
On Wed, 2013-10-16 at 11:32 -0700, Mike Stump wrote:
> On Oct 16, 2013, at 9:26 AM, Tom Tromey wrote:
> > Andreas> You could put it in .dir-locals.el, or put a hook on
> > Andreas> find-file-hook that looks at buffer-file-name.
>
> > We checked in a .dir-locals.el for gdb. I recommend it for GCC
tions (was Re: [PATCH]
> tree_code_name wrapper)
>
> First, we like to wait and let patches bake on mainline before considering
> back
> porting, this has no bake time yet in our tree. Second, only patches that
> impact
> quality enough should be back ported. I tend to think that th
On Oct 16, 2013, at 12:03 PM, Tom Tromey wrote:
> Visit ChangeLog.
> Find a reference to a PR.
> M-x bug-reference-mode
> Click or C-c RET on the PR text
Tested, confirmed it works as expected; thanks.
On Oct 16, 2013, at 1:51 PM, Paulo J. Matos wrote:
> On 16/10/13 19:32, Mike Stump wrote:
>>
>> Committed revision 203715.
>
> Awesome!
> Can I backport your patch to 4_8?
First, we like to wait and let patches bake on mainline before considering back
porting, this has no bake time yet in our
On 16/10/13 19:32, Mike Stump wrote:
Committed revision 203715.
Awesome!
Can I backport your patch to 4_8?
--
PMatos
> "Mike" == Mike Stump writes:
Mike> I've tested it to ensure everything works as expected, except I
Mike> didn't see exactly how to test the bug-reference… If someone knows
Mike> how to test that, I'd appreciate it. If I understand the net
Mike> result of this, it should make the lives of p
On Oct 16, 2013, at 9:26 AM, Tom Tromey wrote:
> Andreas> You could put it in .dir-locals.el, or put a hook on
> Andreas> find-file-hook that looks at buffer-file-name.
> We checked in a .dir-locals.el for gdb. I recommend it for GCC as well.
I've copied the gdb one and updated it for our tree:
Andreas> You could put it in .dir-locals.el, or put a hook on
Andreas> find-file-hook that looks at buffer-file-name.
We checked in a .dir-locals.el for gdb. I recommend it for GCC as well.
The gdb one is appended. You'll at least want to edit the bugzilla URL
to suit.
To make this work, just
"Paulo Matos" writes:
> (haven't found a way to say : 'only use this for GCC sources')
You could put it in .dir-locals.el, or put a hook on find-file-hook that
looks at buffer-file-name.
Andreas.
--
Andreas Schwab, SUSE Labs, sch...@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748
elinek; Richard Biener; Paolo Carlini; gcc-patches@gcc.gnu.org
> Subject: Teaching emacs about GCC coding conventions (was Re: [PATCH]
> tree_code_name wrapper)
>
> On Tue, 2013-10-15 at 13:19 +, Paulo Matos wrote:
> > > -Original Message-
> > > From: Ja
On Tue, 2013-10-15 at 13:19 +, Paulo Matos wrote:
> > -Original Message-
> > From: Jakub Jelinek [mailto:ja...@redhat.com]
> > Sent: 15 October 2013 10:51
> > To: Paulo Matos
> > Cc: Richard Biener; Paolo Carlini; gcc-patches@gcc.gnu.org
> > Subject
> -Original Message-
> From: Paolo Carlini [mailto:paolo.carl...@oracle.com]
> Sent: 16 October 2013 12:54
> To: Richard Biener; Paulo Matos
> Cc: Jakub Jelinek; gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] tree_code_name wrapper
>
> Hi,
>
> bootstrap is
> -Original Message-
> From: Paolo Carlini [mailto:paolo.carl...@oracle.com]
> Sent: 16 October 2013 12:54
> To: Richard Biener; Paulo Matos
> Cc: Jakub Jelinek; gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] tree_code_name wrapper
>
> Hi,
>
> bootstrap is
Hi,
bootstrap is currently broken, I'm going to test and commit the below if
everything goes well.
Thanks,
Paolo.
///
Index: pt.c
===
--- pt.c(revision 203698)
+++ pt.c(working copy)
@@ -12102,7 +1
d Biener; Paolo Carlini; gcc-patches@gcc.gnu.org
>> Subject: Re: [PATCH] tree_code_name wrapper
>>
>> The ChangeLog is still wrong:
>>
>
> OK, sorry.
> If this is ok now I will open a bottle of champagne.
>
> Thank you all for your time reviewing this. Ok to submit?
O
> -Original Message-
> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On
> Behalf Of Jakub Jelinek
> Sent: 15 October 2013 15:45
> To: Paulo Matos
> Cc: Richard Biener; Paolo Carlini; gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] tree_code_
The ChangeLog is still wrong:
On Tue, Oct 15, 2013 at 02:38:31PM +, Paulo Matos wrote:
> 2013-10-15 Paulo Matos
>
> gcc/
> * tree-core.h: Remove extern declaration of tree_code_name.
* tree-core.h (tree_code_name): Remove.
(or Remove external declaration. etc.).
> * t
> -Original Message-
> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On
> Behalf Of Richard Biener
> Sent: 15 October 2013 14:34
> To: Paulo Matos
> Cc: Jakub Jelinek; Paolo Carlini; gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] tree_code
On Tue, Oct 15, 2013 at 3:19 PM, Paulo Matos wrote:
>> -Original Message-
>> From: Jakub Jelinek [mailto:ja...@redhat.com]
>> Sent: 15 October 2013 10:51
>> To: Paulo Matos
>> Cc: Richard Biener; Paolo Carlini; gcc-patches@gcc.gnu.org
>> Subject
> -Original Message-
> From: Jakub Jelinek [mailto:ja...@redhat.com]
> Sent: 15 October 2013 10:51
> To: Paulo Matos
> Cc: Richard Biener; Paolo Carlini; gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] tree_code_name wrapper
>
> On Tue, Oct 15, 2013 at 09:42:17AM
On Tue, Oct 15, 2013 at 09:42:17AM +, Paulo Matos wrote:
> Thanks, regarding the indentation I was convinced we used 2 space
> indentation with maximum line length of 80 characters.
We do, however 8 consecutive spaces in the indentation should be always
replaced by a tab.
> Should I also subm
> -Original Message-
> From: Richard Biener [mailto:richard.guent...@gmail.com]
> Sent: 15 October 2013 10:12
> To: Paolo Carlini
> Cc: Paulo Matos; gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] tree_code_name wrapper
>
>
> Apart from this please make s
On Mon, Oct 14, 2013 at 6:10 PM, Paolo Carlini wrote:
> Hi
>
>
> On 10/14/2013 05:43 PM, Paulo Matos wrote:
>>
>> * cp/error.c (code_to_string): Use new wrapper get_tree_code_name.
>> * cp/cxx-pretty-print.c (pp_cxx_assignment_operator): Use new
>> wrapper get_tree_code_name.
>>
Hi
On 10/14/2013 05:43 PM, Paulo Matos wrote:
* cp/error.c (code_to_string): Use new wrapper get_tree_code_name.
* cp/cxx-pretty-print.c (pp_cxx_assignment_operator): Use new wrapper
get_tree_code_name.
* cp/pt.c (tsubst): Use new wrapper get_tree_code_name.
* cp
> -Original Message-
> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On
> Behalf Of Paulo Matos
> Sent: 14 October 2013 16:43
> To: gcc-patches@gcc.gnu.org
> Subject: [PATCH] tree_code_name wrapper
>
> Hi,
>
> Find attached the
Hi,
Find attached the patch for trunk that creates a wrapper for tree_code_name to
ensure that no invalid tree code is passed on to tree_code_name. All
occurrences of tree_code_name use now use get_tree_code_name. Touched mep, frv,
rs6000, iq2000 backends.
Comments? Ok to submit?
2013-10-14
27 matches
Mail list logo
