Re: [PATCH] target: Fix asm codegen for vfpclasss* and vcvtph2* instructions

2024-10-24 Thread Hongtao Liu
On Fri, Oct 25, 2024 at 12:19 AM Antoni Boucher wrote: > > Thanks. > Did you review the new patch? > Can I push it to master? Ok. > > Le 2024-10-20 à 22 h 01, Hongtao Liu a écrit : > > On Sat, Oct 19, 2024 at 2:06 AM Antoni Boucher wrote: > >> > >> Thanks for the review. > >> Here's the updated p

Re: [PATCH] target: Fix asm codegen for vfpclasss* and vcvtph2* instructions

2024-10-24 Thread Antoni Boucher
Thanks. Did you review the new patch? Can I push it to master? Le 2024-10-20 à 22 h 01, Hongtao Liu a écrit : On Sat, Oct 19, 2024 at 2:06 AM Antoni Boucher wrote: Thanks for the review. Here's the updated patch. Le 2024-10-17 à 21 h 50, Hongtao Liu a écrit : On Fri, Oct 18, 2024 at 9:08 AM

Re: [PATCH] target: Fix asm codegen for vfpclasss* and vcvtph2* instructions

2024-10-20 Thread Hongtao Liu
On Sat, Oct 19, 2024 at 2:06 AM Antoni Boucher wrote: > > Thanks for the review. > Here's the updated patch. > > Le 2024-10-17 à 21 h 50, Hongtao Liu a écrit : > > On Fri, Oct 18, 2024 at 9:08 AM Antoni Boucher wrote: > >> > >> Hi. > >> This is a patch for the bug 116725. > >> I'm not sure if it

Re: [PATCH] target: Fix asm codegen for vfpclasss* and vcvtph2* instructions

2024-10-18 Thread Antoni Boucher
x512dq_vmfpclass" UNSPEC_FPCLASS) (const_int 1)))] "TARGET_AVX512DQ || VALID_AVX512FP16_REG_MODE(mode)" - "vfpclass\t{%2, %1, %0|%0, %1, %2}"; +;; %X1 so that we don't emit any *WORD PTR for -masm=intel. + "vfpclass\t{%2, %1, %0|%0, %X1, %2}&qu

Re: [PATCH] target: Fix asm codegen for vfpclasss* and vcvtph2* instructions

2024-10-17 Thread Hongtao Liu
On Fri, Oct 18, 2024 at 9:08 AM Antoni Boucher wrote: > > Hi. > This is a patch for the bug 116725. > I'm not sure if it is a good fix, but it seems to do the job. > If you have suggestions for better comments than what I wrote that would > explain what's happening, I'm open to suggestions. >@@ -

[PATCH] target: Fix asm codegen for vfpclasss* and vcvtph2* instructions

2024-10-17 Thread Antoni Boucher
target: Fix asm codegen for vfpclasss* and vcvtph2* instructions This only happens when using -masm=intel. gcc/ChangeLog: PR target/116725 * config/i386/sse.md: Fix asm generation. gcc/testsuite/ChangeLog: PR target/116725 * gcc.target/i386/