Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2025-01-22 Thread Andrew Pinski
On Tue, Jan 21, 2025 at 5:45 PM Andrew Pinski wrote: > > On Thu, Aug 8, 2024 at 2:07 PM Andrew Pinski wrote: > > > > On Fri, Aug 2, 2024 at 7:30 AM Jeff Law wrote: > > > > > > > > > > > > On 8/1/24 4:12 AM, Surya Kumari Jangala wrote: > > > > lra: emit caller-save register spills before call ins

Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2025-01-21 Thread Andrew Pinski
On Thu, Aug 8, 2024 at 2:07 PM Andrew Pinski wrote: > > On Fri, Aug 2, 2024 at 7:30 AM Jeff Law wrote: > > > > > > > > On 8/1/24 4:12 AM, Surya Kumari Jangala wrote: > > > lra: emit caller-save register spills before call insn [PR116028] > > > > > > LRA emits insns to save caller-save registers i

Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2024-09-30 Thread Christophe Lyon
Hi! Sorry for replying late... On Sat, 10 Aug 2024 at 05:15, Andrew Pinski wrote: > > On Fri, Aug 9, 2024 at 8:11 PM Xi Ruoyao wrote: > > > > On Fri, 2024-08-09 at 17:55 -0400, Vladimir Makarov wrote: > > > > > Still, for GCC developer novice, I think it is important to test all > > > major ta

Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2024-08-11 Thread Mark Wielaard
Hi, On Fri, Aug 09, 2024 at 08:15:31PM -0700, Andrew Pinski wrote: > I had been wondering the same until I looked into it earlier today. > Linaro CI's does `--disable-bootstrap` and there was no extra > testsuite failures with the patch. > So Linaro CI's is not catching all the bugs that a develop

Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2024-08-09 Thread Andrew Pinski
On Fri, Aug 9, 2024 at 8:11 PM Xi Ruoyao wrote: > > On Fri, 2024-08-09 at 17:55 -0400, Vladimir Makarov wrote: > > > Still, for GCC developer novice, I think it is important to test all > > major targets and aarch64 (one target on which bootstrap was broken) is > > the 2nd most important target. >

Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2024-08-09 Thread Xi Ruoyao
On Fri, 2024-08-09 at 17:55 -0400, Vladimir Makarov wrote: > Still, for GCC developer novice, I think it is important to test all > major targets and aarch64 (one target on which bootstrap was broken) is > the 2nd most important target. Linaro CI will complain (via off-list email) if a patch po

Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2024-08-09 Thread Vladimir Makarov
On 8/9/24 17:00, Peter Bergner wrote: On 8/9/24 12:02 PM, Vladimir Makarov wrote: I believe your should reverse the original patch and all the patches you submitted to fix the issues with the original patch. I agree this commit should be reverted and Kyrill has pushed that already, so bootstr

Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2024-08-09 Thread Peter Bergner
On 8/9/24 12:02 PM, Vladimir Makarov wrote: > I believe your should reverse the original patch and all the patches you > submitted to fix the issues with the original patch. I agree this commit should be reverted and Kyrill has pushed that already, so bootstrap should be restored now. Thank you K

Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2024-08-09 Thread Kyrylo Tkachov
> On 9 Aug 2024, at 19:02, Vladimir Makarov wrote: > > External email: Use caution opening links or attachments > > > On 8/9/24 08:58, Surya Kumari Jangala wrote: >> I am looking into this failure. >> > Sorry for delay with this email. I was on vacation. > > I believe your should reverse t

Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2024-08-09 Thread Vladimir Makarov
On 8/9/24 08:58, Surya Kumari Jangala wrote: I am looking into this failure. Sorry for delay with this email.  I was on vacation. I believe your should reverse the original patch and all the patches you submitted to fix the issues with the original patch. This is a standard procedure in s

Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2024-08-09 Thread Jeff Law
On 8/9/24 6:58 AM, Surya Kumari Jangala wrote: I am looking into this failure. Also note that it appears that this change is causing either an infinite loop or severe compile-time regression for Wrestrict. Build a cross for xstormy16-elf. You don't need a full toolchain, just compiler shou

Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2024-08-09 Thread Surya Kumari Jangala
I am looking into this failure. Thanks, Surya On 09/08/24 2:37 am, Andrew Pinski wrote: > On Fri, Aug 2, 2024 at 7:30 AM Jeff Law wrote: >> >> >> >> On 8/1/24 4:12 AM, Surya Kumari Jangala wrote: >>> lra: emit caller-save register spills before call insn [PR116028] >>> >>> LRA emits insns to sav

Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2024-08-09 Thread Mark Wielaard
Hi, On Thu, Aug 08, 2024 at 02:07:50PM -0700, Andrew Pinski wrote: > On Fri, Aug 2, 2024 at 7:30 AM Jeff Law wrote: > > > 2024-08-01 Surya Kumari Jangala > > > > > > gcc/ > > > PR rtl-optimization/PR116028 > > > * lra-constraints.cc (split_reg): Spill register before call > > >

Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2024-08-08 Thread Andrew Pinski
On Fri, Aug 2, 2024 at 7:30 AM Jeff Law wrote: > > > > On 8/1/24 4:12 AM, Surya Kumari Jangala wrote: > > lra: emit caller-save register spills before call insn [PR116028] > > > > LRA emits insns to save caller-save registers in the > > inheritance/splitting pass. In this pass, LRA builds EBBs (Ex

Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2024-08-02 Thread Jeff Law
On 8/1/24 4:12 AM, Surya Kumari Jangala wrote: lra: emit caller-save register spills before call insn [PR116028] LRA emits insns to save caller-save registers in the inheritance/splitting pass. In this pass, LRA builds EBBs (Extended Basic Block) and traverses the insns in the EBBs in reverse

[PATCH] lra: emit caller-save register spills before call insn [PR116028]

2024-08-01 Thread Surya Kumari Jangala
lra: emit caller-save register spills before call insn [PR116028] LRA emits insns to save caller-save registers in the inheritance/splitting pass. In this pass, LRA builds EBBs (Extended Basic Block) and traverses the insns in the EBBs in reverse order from the last insn to the first insn. When LR