On 8/9/24 12:02 PM, Vladimir Makarov wrote: > I believe your should reverse the original patch and all the patches you > submitted to fix the issues with the original patch.
I agree this commit should be reverted and Kyrill has pushed that already, so bootstrap should be restored now. Thank you Kyrill. Surya was testing her revert commit too, but was waiting for her bootstrap to complete before pushing (per process rules). It's just the cfarm systems she has access to were being slow. I do *not* agree that all the previous patches should be reverted, since they fixed *real* bugs and really only exposed other latent issues which Surya has been working on. > You should do a better testing you patches It is not correct to presume she did not test her patches thoroughly. I know she has, but with the large number of supported architectures and ABIs on those architectures, she cannot possibly test everything. That's why we have stage1 and our patch revert process. Peter
