Re: [PATCH] late-combine: Preserve INSN_CODE when modifying notes [PR116343]

2024-08-24 Thread Georg-Johann Lay
Am 23.08.24 um 17:47 schrieb Jeff Law: On 8/23/24 9:45 AM, Richard Biener wrote: Am 23.08.2024 um 16:49 schrieb Jeff Law : On 8/23/24 6:02 AM, Georg-Johann Lay wrote: Hi, this fails on machines that don't support scheduling: cc1: warning: instruction scheduling not supported on this target ma

Re: [PATCH] late-combine: Preserve INSN_CODE when modifying notes [PR116343]

2024-08-23 Thread Georg-Johann Lay
Am 23.08.24 um 17:45 schrieb Richard Biener: Am 23.08.2024 um 16:49 schrieb Jeff Law : On 8/23/24 6:02 AM, Georg-Johann Lay wrote: Hi, this fails on machines that don't support scheduling: cc1: warning: instruction scheduling not supported on this target machine FAIL: gcc.dg/torture/pr116343.c

Re: [PATCH] late-combine: Preserve INSN_CODE when modifying notes [PR116343]

2024-08-23 Thread Jeff Law
On 8/23/24 9:45 AM, Richard Biener wrote: Am 23.08.2024 um 16:49 schrieb Jeff Law :  On 8/23/24 6:02 AM, Georg-Johann Lay wrote: Hi, this fails on machines that don't support scheduling: cc1: warning: instruction scheduling not supported on this target machine FAIL: gcc.dg/torture/pr11

Re: [PATCH] late-combine: Preserve INSN_CODE when modifying notes [PR116343]

2024-08-23 Thread Richard Biener
> Am 23.08.2024 um 16:49 schrieb Jeff Law : > >  > >> On 8/23/24 6:02 AM, Georg-Johann Lay wrote: >> >> Hi, this fails on machines that don't support scheduling: >> cc1: warning: instruction scheduling not supported on this target machine >> FAIL: gcc.dg/torture/pr116343.c -O0 (test for e

Re: [PATCH] late-combine: Preserve INSN_CODE when modifying notes [PR116343]

2024-08-23 Thread Jeff Law
On 8/23/24 6:02 AM, Georg-Johann Lay wrote: Hi, this fails on machines that don't support scheduling: cc1: warning: instruction scheduling not supported on this target machine FAIL: gcc.dg/torture/pr116343.c   -O0  (test for excess errors) Excess errors: cc1: warning: instruction schedulin

Re: [PATCH] late-combine: Preserve INSN_CODE when modifying notes [PR116343]

2024-08-23 Thread Georg-Johann Lay
Am 15.08.24 um 10:45 schrieb Richard Sandiford: When it removes a definition, late-combine tries to update all uses in notes. It does this using the same insn_propagation class that it uses for patterns. However, insn_propagation uses validate_change, which in turn resets the INSN_CODE. This i

Re: [PATCH] late-combine: Preserve INSN_CODE when modifying notes [PR116343]

2024-08-15 Thread Jeff Law
On 8/15/24 2:45 AM, Richard Sandiford wrote: When it removes a definition, late-combine tries to update all uses in notes. It does this using the same insn_propagation class that it uses for patterns. However, insn_propagation uses validate_change, which in turn resets the INSN_CODE. This i

[PATCH] late-combine: Preserve INSN_CODE when modifying notes [PR116343]

2024-08-15 Thread Richard Sandiford
When it removes a definition, late-combine tries to update all uses in notes. It does this using the same insn_propagation class that it uses for patterns. However, insn_propagation uses validate_change, which in turn resets the INSN_CODE. This is inefficient in the best case, since it forces th