Re: [PATCH] Support LABEL_DECL in %qD directive.

2021-04-21 Thread Martin Liška
On 4/21/21 1:26 PM, Martin Liška wrote: > On 4/21/21 12:56 PM, Jakub Jelinek wrote: >> On Wed, Apr 21, 2021 at 12:52:42PM +0200, Martin Liška wrote: >>> On 4/21/21 11:04 AM, Jakub Jelinek wrote: Wouldn't it be better to be consistent with tree-pretty-print.c on this or perhaps just call d

Re: [PATCH] Support LABEL_DECL in %qD directive.

2021-04-21 Thread Martin Liška
On 4/21/21 12:56 PM, Jakub Jelinek wrote: > On Wed, Apr 21, 2021 at 12:52:42PM +0200, Martin Liška wrote: >> On 4/21/21 11:04 AM, Jakub Jelinek wrote: >>> Wouldn't it be better to be consistent with tree-pretty-print.c on this >>> or perhaps just call dump_generic_node or whatever is used to dump >

Re: [PATCH] Support LABEL_DECL in %qD directive.

2021-04-21 Thread Jakub Jelinek via Gcc-patches
On Wed, Apr 21, 2021 at 12:52:42PM +0200, Martin Liška wrote: > On 4/21/21 11:04 AM, Jakub Jelinek wrote: > > Wouldn't it be better to be consistent with tree-pretty-print.c on this > > or perhaps just call dump_generic_node or whatever is used to dump > > those e.g. for C? > > Yes, I'm going to i

Re: [PATCH] Support LABEL_DECL in %qD directive.

2021-04-21 Thread Martin Liška
On 4/21/21 11:04 AM, Jakub Jelinek wrote: > Wouldn't it be better to be consistent with tree-pretty-print.c on this > or perhaps just call dump_generic_node or whatever is used to dump > those e.g. for C? Yes, I'm going to install patch that does: + if (DECL_NAME (t)) + pp_cxx_tree_id

Re: [PATCH] Support LABEL_DECL in %qD directive.

2021-04-21 Thread Richard Biener via Gcc-patches
On Wed, Apr 21, 2021 at 10:49 AM Martin Liška wrote: > > Hey. > > The patch is a refactoring and simplification in tree-cfg.c. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > I verified that the error messages are correctly printed. > > Ready to be installed? OK. Rich

Re: [PATCH] Support LABEL_DECL in %qD directive.

2021-04-21 Thread Jakub Jelinek via Gcc-patches
On Wed, Apr 21, 2021 at 09:56:23AM +0200, Martin Liška wrote: > The patch is a refactoring and simplification in tree-cfg.c. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > I verified that the error messages are correctly printed. > > Ready to be installed? > Thanks,

[PATCH] Support LABEL_DECL in %qD directive.

2021-04-21 Thread Martin Liška
Hey. The patch is a refactoring and simplification in tree-cfg.c. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. I verified that the error messages are correctly printed. Ready to be installed? Thanks, Martin gcc/cp/ChangeLog: * error.c (dump_decl): Support anon