On Dec 16, 2014, at 4:49 PM, Sergio Durigan Junior wrote:
>
>> Ok.
>
> Can you commit this one for me, please?
Committed revision 218843.
If anyone discovers any nasties, pre-approved to pull the patch out or resolve
the issue in the obvious way. I’d hate to impact the folks with this change
On Tuesday, December 16 2014, Mike Stump wrote:
> Well, I’d still say that ‘\0’ in the output of tools is antisocial and that
> is the real bug that needs to be fixed.
I agree with you, and I am working on a patch to fix GDB, too.
> That aside, it is reasonable to protect testing from poorly be
On Dec 16, 2014, at 1:43 PM, Sergio Durigan Junior wrote:
> On Tuesday, December 16 2014, Mike Stump wrote:
>
>> So, either, the tool should not generate 0 in the output, which, is rather
>> anti-social, or one should strip the funny characters in a more portable
>> fashion.
>>
>> tr and cat -
On Tuesday, December 16 2014, Mike Stump wrote:
> So, either, the tool should not generate 0 in the output, which, is rather
> anti-social, or one should strip the funny characters in a more portable
> fashion.
>
> tr and cat -v come to mind; both should be pretty portable.
>
>> OK to apply?
>
>
On Tuesday, December 16 2014, Jakub Jelinek wrote:
> On Tue, Dec 16, 2014 at 09:36:33AM +, Pedro Alves wrote:
>> On 12/15/2014 11:00 PM, Sergio Durigan Junior wrote:
>> > +# Check if grep supports the '--text' option.
>> > +
>> > +GREP_TEXT_OPT="--text"
>> > +if grep --text 2>&1 | grep "unreco
On 12/16/2014 10:03 AM, Mike Stump wrote:
>> > input_interrupt, count = 0 c = 0 ('^@')
>> >
>> > (The ^@ above is the NUL byte.)
> So, either, the tool should not generate 0 in the output, which, is rather
> anti-social,
Yeah, this is actually a gdbserver debug output that misses an "if debugg
On Dec 15, 2014, at 2:37 PM, Sergio Durigan Junior wrote:
> This weekend I was running GDB's testsuite with many options enabled,
> and I noticed that, for some specific configurations (specifically
> when testing gdbserver), I was getting the following error:
> Binary file outputs/gdb.base/gdb-
On Tue, Dec 16, 2014 at 09:36:33AM +, Pedro Alves wrote:
> On 12/15/2014 11:00 PM, Sergio Durigan Junior wrote:
> > +# Check if grep supports the '--text' option.
> > +
> > +GREP_TEXT_OPT="--text"
> > +if grep --text 2>&1 | grep "unrecognized option" > /dev/null 2>&1 ; then
> > + GREP_TEXT_OPT
On 12/15/2014 11:00 PM, Sergio Durigan Junior wrote:
> +# Check if grep supports the '--text' option.
> +
> +GREP_TEXT_OPT="--text"
> +if grep --text 2>&1 | grep "unrecognized option" > /dev/null 2>&1 ; then
> + GREP_TEXT_OPT=""
> +fi
> +
That assumes all greps output "unrecognized option" on
unr
On Monday, December 15 2014, Jakub Jelinek wrote:
> I'd be surprised if all versions of grep supported --text option (e.g. POSIX
> doesn't mention the -a nor --text options), guess
> you'd need to check for that first (early in the script) and add it only if
> it works.
Thanks for the review, Jak
On Mon, Dec 15, 2014 at 05:37:03PM -0500, Sergio Durigan Junior wrote:
> 2014-12-14 Sergio Durigan Junior
>
> * dg-extract-results.sh: Pass '--text' option to grep when
> filtering .{sum,log} files, which may contain binary data.
I'd be surprised if all versions of grep supported -
This weekend I was running GDB's testsuite with many options enabled,
and I noticed that, for some specific configurations (specifically
when testing gdbserver), I was getting the following error:
dg-extract-results.sh: sum files are for multiple tools, specify a tool
I remembered seeing this a
12 matches
Mail list logo
