Re: [PATCH] Fix up one mishandled plural in diagnostics in gimple-ssa-sprintf.c

2017-12-20 Thread David Malcolm
On Tue, 2017-12-19 at 18:58 +0100, Jakub Jelinek wrote: > On Tue, Dec 19, 2017 at 10:49:07AM -0700, Martin Sebor wrote: > > Can the math be moved into inform_n (and warning_n) itself? > > No. I'm against having dozens of inform_n and warning_n etc. > overloads, it is already bad enough we have so

Re: [PATCH] Fix up one mishandled plural in diagnostics in gimple-ssa-sprintf.c

2017-12-19 Thread Jeff Law
On 12/19/2017 10:20 AM, Jakub Jelinek wrote: > Hi! > > This inform is correct in english, but wrong in many other languages. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > 2017-12-19 Jakub Jelinek > > * gimple-ssa-sprintf.c (format_directive): Use inform_n

Re: [PATCH] Fix up one mishandled plural in diagnostics in gimple-ssa-sprintf.c

2017-12-19 Thread Martin Sebor
On 12/19/2017 11:28 AM, Jakub Jelinek wrote: On Tue, Dec 19, 2017 at 11:19:44AM -0700, Martin Sebor wrote: On 12/19/2017 10:58 AM, Jakub Jelinek wrote: On Tue, Dec 19, 2017 at 10:49:07AM -0700, Martin Sebor wrote: Can the math be moved into inform_n (and warning_n) itself? No. I'm against h

Re: [PATCH] Fix up one mishandled plural in diagnostics in gimple-ssa-sprintf.c

2017-12-19 Thread Jakub Jelinek
On Tue, Dec 19, 2017 at 11:19:44AM -0700, Martin Sebor wrote: > On 12/19/2017 10:58 AM, Jakub Jelinek wrote: > > On Tue, Dec 19, 2017 at 10:49:07AM -0700, Martin Sebor wrote: > > > Can the math be moved into inform_n (and warning_n) itself? > > > > No. I'm against having dozens of inform_n and wa

Re: [PATCH] Fix up one mishandled plural in diagnostics in gimple-ssa-sprintf.c

2017-12-19 Thread Martin Sebor
On 12/19/2017 10:58 AM, Jakub Jelinek wrote: On Tue, Dec 19, 2017 at 10:49:07AM -0700, Martin Sebor wrote: Can the math be moved into inform_n (and warning_n) itself? No. I'm against having dozens of inform_n and warning_n etc. The question/suggestion is to change the existing inform_n and

Re: [PATCH] Fix up one mishandled plural in diagnostics in gimple-ssa-sprintf.c

2017-12-19 Thread Jakub Jelinek
On Tue, Dec 19, 2017 at 07:02:38PM +0100, Richard Biener wrote: > On December 19, 2017 6:58:15 PM GMT+01:00, Jakub Jelinek > wrote: > >On Tue, Dec 19, 2017 at 10:49:07AM -0700, Martin Sebor wrote: > >> Can the math be moved into inform_n (and warning_n) itself? > > > >No. I'm against having doze

Re: [PATCH] Fix up one mishandled plural in diagnostics in gimple-ssa-sprintf.c

2017-12-19 Thread Richard Biener
On December 19, 2017 6:58:15 PM GMT+01:00, Jakub Jelinek wrote: >On Tue, Dec 19, 2017 at 10:49:07AM -0700, Martin Sebor wrote: >> Can the math be moved into inform_n (and warning_n) itself? > >No. I'm against having dozens of inform_n and warning_n etc. >overloads, it is already bad enough we ha

Re: [PATCH] Fix up one mishandled plural in diagnostics in gimple-ssa-sprintf.c

2017-12-19 Thread Jakub Jelinek
On Tue, Dec 19, 2017 at 10:49:07AM -0700, Martin Sebor wrote: > Can the math be moved into inform_n (and warning_n) itself? No. I'm against having dozens of inform_n and warning_n etc. overloads, it is already bad enough we have so many diagnostics entry points now that putting breakpoints on the

Re: [PATCH] Fix up one mishandled plural in diagnostics in gimple-ssa-sprintf.c

2017-12-19 Thread Martin Sebor
On 12/19/2017 10:20 AM, Jakub Jelinek wrote: Hi! This inform is correct in english, but wrong in many other languages. I think someone already mentioned this in another review but the computation below is far from intuitive: + ? (fmtres.range.likely % 100) + 100 +

[PATCH] Fix up one mishandled plural in diagnostics in gimple-ssa-sprintf.c

2017-12-19 Thread Jakub Jelinek
Hi! This inform is correct in english, but wrong in many other languages. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2017-12-19 Jakub Jelinek * gimple-ssa-sprintf.c (format_directive): Use inform_n instead of inform with hardcoded english plural hand