Re: [PATCH] Analyzer: Refactor callstring to work with pairs of supernodes.

2021-07-26 Thread David Malcolm via Gcc-patches
On Mon, 2021-07-26 at 21:04 +0530, Ankur Saini wrote: > > Here is the latest patch after fixing all the nit picks and issues > pointed out by everyone. > Looks good to me. Thanks Dave

Re: [PATCH] Analyzer: Refactor callstring to work with pairs of supernodes.

2021-07-26 Thread Ankur Saini via Gcc-patches
Here is the latest patch after fixing all the nit picks and issues pointed out by everyone. call_string.patch Description: Binary data Thanks you - Ankur

Re: [PATCH] Analyzer: Refactor callstring to work with pairs of supernodes.

2021-07-26 Thread Ankur Saini via Gcc-patches
> On 25-Jul-2021, at 7:59 PM, Prathamesh Kulkarni > wrote: > > !(*this == other) Thanks for the suggestion. Here is the updated patch. Thank you - Ankur

Re: [PATCH] Analyzer: Refactor callstring to work with pairs of supernodes.

2021-07-25 Thread Prathamesh Kulkarni via Gcc-patches
On Sun, 25 Jul 2021 at 16:03, Ankur Saini via Gcc-patches wrote: > > Here is the new patch after fixing all the issues pointed out in the previous > version. Just a nitpick: +/* call_string::element_t's inequality operator. */ +bool +call_string::element_t::operator!= (const call_string::elemen

Re: [PATCH] Analyzer: Refactor callstring to work with pairs of supernodes.

2021-07-25 Thread Ankur Saini via Gcc-patches
Here is the new patch after fixing all the issues pointed out in the previous version. call_string.patch Description: Binary data — Question : 1. The mail id I am using here to send the patch ( arsenic.second...@gmail.com ) and the mail id in the patch ( arse...@sourceware.org ) are differ

Re: [PATCH] Analyzer: Refactor callstring to work with pairs of supernodes.

2021-07-24 Thread David Malcolm via Gcc-patches
On Sat, 2021-07-24 at 15:22 +0530, Ankur Saini wrote: > The patch generalises how analyzer's call_string tracks function calls, > including the calls that doesn’t have an underlying call graph edge, > making it possible to work with function calls which are not discovered > by GCC's middle end. >

[PATCH] Analyzer: Refactor callstring to work with pairs of supernodes.

2021-07-24 Thread Ankur Saini via Gcc-patches
The patch generalises how analyzer's call_string tracks function calls, including the calls that doesn’t have an underlying call graph edge, making it possible to work with function calls which are not discovered by GCC's middle end. Successfully bootstrapped and completed regress tests on x86_

[PATCH] Analyzer: Refactor callstring to work with pairs of supernodes.

2021-07-15 Thread Ankur Saini via Gcc-patches
2021-07-12 Ankur Saini gcc/analyzer/ChangeLog: * call-string.cc (call_string::element_t::operator==): New operator. (call_String::element_t::operator!=): New operator. (call_string::element_t::get_caller_function): New function. (call_string::element_t::get_calle