On Sun, 25 Jul 2021 at 16:03, Ankur Saini via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Here is the new patch after fixing all the issues pointed out in the previous
> version.
Just a nitpick:
+/* call_string::element_t's inequality operator. */
+bool
+call_string::element_t::operator!= (const call_string::element_t &other) const
+{
+ if (m_caller != other.m_caller || m_callee != other.m_callee)
+ return true;
+ return false;
+}
Since you define operator== above, perhaps just implement operator != as:
return !(*this == other) ?
Thanks,
Prathamesh
>
>
>
> —
>
> Question :
>
> 1. The mail id I am using here to send the patch (
> arsenic.second...@gmail.com ) and the mail id in the patch (
> arse...@sourceware.org ) are different from one and other, will this affect
> the process in any ways ?
>
>
> Thanks
> - Ankur
