Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS env var

2020-01-23 Thread Bernd Edlinger
Hi, I just wanted to ask, if there was any progress on this? Thanks Bernd. On 12/21/19 10:50 AM, Bernd Edlinger wrote: > Hi David, > > thanks for fixing this issue. > > Just one comment: > >> +[DIAGNOSTICS_URLS_DEFAULT=DIAGNOSTICS_URL_AUTO]) >> +AC_DEFINE_UNQUOTED(DIAGNOSTICS_URLS_DEFAULT,

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS env var

2019-12-21 Thread Bernd Edlinger
Hi David, thanks for fixing this issue. Just one comment: > +[DIAGNOSTICS_URLS_DEFAULT=DIAGNOSTICS_URL_AUTO]) > +AC_DEFINE_UNQUOTED(DIAGNOSTICS_URLS_DEFAULT, $DIAGNOSTICS_URLS_DEFAULT, > +[The default for -fdiagnostics-urls option]) I think for a feature as disruptive as this, w

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS env var

2019-12-20 Thread 王昊然
I think this is good idea since it is consistent with env var GCC_COLORS -- the color support will be disabled even with -fdiagnostics-color=always, if GCC_COLORS is set to empty. And I has experienced more serious problem when I ssh(1) to the remote machine from a even older terminal, GNOME Termin

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS env var

2019-12-19 Thread Jakub Jelinek
On Thu, Dec 19, 2019 at 03:24:19PM -0500, David Malcolm wrote: > Currently -fdiagnostics-urls defaults to "auto" and this works > (e.g. for recent gnome-terminal, and is gracefully discarded by > konsole5), but there have been reports of incompatibilities of the > feature with various other termina

[PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS env var

2019-12-19 Thread David Malcolm
On Mon, 2019-12-16 at 10:39 +0800, 王昊然 wrote: > > Which revision of gcc is this? > Using built-in specs. > COLLECT_GCC=/opt/gcc-10.0-20191208/bin/gcc-10.0-20191208 > COLLECT_LTO_WRAPPER=/opt/gcc-10.0-20191208/bin/../lib/gcc/x86_64-pc- > linux-gnu/10.0.0/lto-wrapper > Target: x86_64-pc-linux-gnu > C